Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github md "Note" and "Tip" blocks in Android shell README #50664

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix github md "Note" and "Tip" blocks in Android shell README #50664

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93e3c97
fix md
Feb 14, 2024
277edca
fix actually
Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions shell/platform/android/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ flutter run \
--local-engine=$ENGINE/out/android_debug_unopt_arm64
```

> ![NOTE]
> [!NOTE]
> External texture rendering on Android is based on the device API level. For
> example to test the OpenGLES branch (which uses `SurfaceTexture`), you'll
> typically need an older device or emulator with an API version 29 or lower.
Expand All @@ -105,7 +105,7 @@ See [our wiki](https://github.com/flutter/flutter/wiki/Testing-the-engine#java--

How to edit and contribute to the Android embedder.

> ![TIP]
> [!TIP]
> This guide assumes you already have a working Engine development environment:
>
> - [Setting up the Engine development environment](https://github.com/flutter/flutter/wiki/Setting-up-the-Engine-development-environment)
Expand Down Expand Up @@ -149,7 +149,8 @@ completion:

![Example](https://github.com/flutter/flutter/assets/168174/8a75dd27-66e1-4c4f-88af-667a73b909b6)

> ![NOTE] > `--compile-commands-dir` must point to an Android build output:
> [!NOTE]
> `--compile-commands-dir` must point to an Android build output:
>
> ```jsonc
> {
Expand Down