[Windows] Improve FlutterWindow unit tests
#50676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
approved these changes
Feb 15, 2024
8 tasks
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
…143565) flutter/engine@b7103bc...dd530f1 2024-02-16 [email protected] Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709) 2024-02-16 [email protected] Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708) 2024-02-16 [email protected] [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676) 2024-02-16 [email protected] [et] Adds a logger (flutter/engine#50693) 2024-02-15 [email protected] Update README.md (flutter/engine#50702) 2024-02-15 [email protected] Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704) 2024-02-15 [email protected] Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608) 2024-02-15 [email protected] Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700) 2024-02-15 [email protected] Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699) 2024-02-15 [email protected] [Android] Remove the unnecessary parent interface. (flutter/engine#50677) 2024-02-15 [email protected] [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698) 2024-02-15 [email protected] Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696) 2024-02-15 6844906[email protected] [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 [email protected] [Impeller] Updated benchmarks (flutter/engine#50694) 2024-02-15 [email protected] Documentation for test timeouts. (flutter/engine#50687) 2024-02-15 [email protected] Shift some Linux builders from Goma to RBE (flutter/engine#50653) 2024-02-15 [email protected] Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was split from #50673 to reduce noise in that PR.
Previously
MockFlutterWindowcalled aFlutterWindowconstructor which created a window & resized it. This change introduces a minimal base constructor for testing purposes. This allows us to skip some noisy mocks in a subsequent change: #50673This also introduces a fixture for the window unit tests.
Part of flutter/flutter#137267
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.