Better filtering for Android `scenario_app` runner. #50937

matanlurey · 2024-02-24T03:03:09Z

🍴 'd from #50933, will rebase when merged.

Closes flutter/flutter#143458.

A picture is a 1000 words:

This is still noisy, but at least all the output appears to be part of the execution.

As you recall, the full logs are always available in the FLUTTER_LOGS_DIR output.

…-filtering

gaaclarke

LGTM. Just a few suggestions for clarity and versatility.

gaaclarke · 2024-02-26T17:41:14Z

testing/scenario_app/bin/utils/adb_logcat_filtering.dart

  //
  // This regex is simple versus being more precise. Feel free to improve it.
-  static final RegExp _pattern = RegExp(r'([^A-Z]*)([A-Z])\s([^:]*)\:\s(.*)');
+  static final RegExp _pattern = RegExp(r'(\d+-\d+\s[\d|:]+\.\d+)\s+(\d+)\s+(\d+)\s(\w)\s(\S+)\s*:\s*(.*)');


Can you put those comments inline in the regex? I'm not sure if the dart regex parser supports them.

I cannot unfortunately (Dart regex support lacking).

gaaclarke · 2024-02-26T17:47:10Z

testing/scenario_app/bin/run_android_tests.dart

@@ -311,27 +327,26 @@ Future<void> _run({
      final (Future<int> logcatExitCode, Stream<String> logcatOutput) = getProcessStreams(logcatProcess);

      logcatProcessExitCode = logcatExitCode;
+      String? filterToProcessId;


I found this name really confusing. The gist is that it is the process id we are filtering for right filterProcessId seems more clear to me.

Yeah I agree, cleaned it up a bit and added comments.

gaaclarke · 2024-02-26T17:50:33Z

testing/scenario_app/bin/run_android_tests.dart

+          return;
+        }
+
+        filterToProcessId ??= adbLogLine.tryParseProcess();


So the intention is no printing until we've parsed a process? It might be worth adding a comment here for that.

Agreed, done.

gaaclarke · 2024-02-26T17:53:11Z

testing/scenario_app/bin/utils/logs.dart

+}
+
+void logWarning(String msg) {
+  stderr.writeln('$_yellow$msg$_reset');


nit: a function that takes in a color would be nice so not everyone has to remember to reset the color. colorLog(stderr, _yellow, "hello").

Groovy! Done.

gaaclarke · 2024-02-26T17:56:33Z

testing/scenario_app/tool/logcat_reader.dart

+/// `adb logcat` and explain what log tag names are most common.
+void main(List<String> args) {
+  if (args case [final String path]) {
+    final List<AdbLogLine> parsed = io.File(path)


nit: Ideally this tool would work by streaming from stdout. That way it wouldn't be limited by memory size and you could say stuff like tail foo.log | logcat_reader or adb logcat | logcat_reader.

Yeah this is intended to read from our stored logcat.txt, not necessarily the live process. I edited the tool to make that more clear!

dnfield

Consider adding some test logs that parse the way you want them to so that we know in the future what the logcat you were basing this on looked like.

dnfield · 2024-02-26T19:20:41Z

(but LGTM)

…r/engine#50937)

…144208) flutter/engine@04ff286...0bc21ea 2024-02-27 [email protected] Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989) 2024-02-27 [email protected] Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter/engine#50998) 2024-02-27 [email protected] Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996) 2024-02-27 [email protected] Fix usage of `--out-dir` with a relative path. (flutter/engine#50992) 2024-02-27 [email protected] Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter/engine#50991) 2024-02-27 [email protected] Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate Android `scenario_app` to the `SurfaceProducer` API (#50993)" (flutter/engine#50995) 2024-02-27 [email protected] Migrate Android `scenario_app` to the `SurfaceProducer` API (flutter/engine#50993) 2024-02-27 [email protected] Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985) 2024-02-26 [email protected] Refactor args parsing/environment constructor for `scenario_app` (flutter/engine#50980) 2024-02-26 [email protected] [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981) 2024-02-26 [email protected] [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983) 2024-02-26 [email protected] Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979) 2024-02-26 [email protected] Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327) 2024-02-26 [email protected] [Impeller] disble render pass caches. (flutter/engine#50976) 2024-02-26 [email protected] Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971) 2024-02-26 [email protected] [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883) 2024-02-26 [email protected] Better filtering for Android `scenario_app` runner. (flutter/engine#50937) 2024-02-26 [email protected] Make sure to call `setHeightOverride` as well on TextStyle and StrutStyle (flutter/engine#50920) 2024-02-26 [email protected] Correctly offset the cull rect of the opacity layer. (flutter/engine#50928) 2024-02-26 [email protected] Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kLvCWEgbL1VT to JCdhkDSFXzHy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

matanlurey added 6 commits February 23, 2024 16:17

Actually list all sources for scenario_app target.

84cef7b

Start work on better filtering.

794caf7

Finish filtering.

22f83c3

++

68a5de9

++

2b16508

Merge remote-tracking branch 'upstream/main' into scenario_app-better…

18bcbc3

…-filtering

matanlurey marked this pull request as ready for review February 26, 2024 17:32

matanlurey requested review from dnfield and gaaclarke February 26, 2024 17:32

gaaclarke approved these changes Feb 26, 2024

View reviewed changes

matanlurey added 2 commits February 26, 2024 10:22

++

34a5f3e

++

14f7bd9

dnfield reviewed Feb 26, 2024

View reviewed changes

matanlurey merged commit b28cfbb into flutter:main Feb 26, 2024
23 checks passed

matanlurey deleted the scenario_app-better-filtering branch February 26, 2024 19:36

matanlurey mentioned this pull request Feb 26, 2024

Add a test of the ADB log parsing flutter/flutter#144164

Closed

engine-flutter-autoroll mentioned this pull request Feb 26, 2024

Roll Flutter Engine from 04ff2868ce80 to b28cfbbb4d90 (4 revisions) flutter/flutter#144171

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2024

b28cfbbb4 Better filtering for Android scenario_app runner. (flutte…

9592f4e

…r/engine#50937)

engine-flutter-autoroll mentioned this pull request Feb 26, 2024

Roll Flutter Engine from 04ff2868ce80 to d8129b98fdf2 (6 revisions) flutter/flutter#144177

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2024

b28cfbbb4 Better filtering for Android scenario_app runner. (flutte…

cb6d035

…r/engine#50937)

engine-flutter-autoroll mentioned this pull request Feb 26, 2024

Roll Flutter Engine from 04ff2868ce80 to c24744983bc1 (8 revisions) flutter/flutter#144188

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2024

b28cfbbb4 Better filtering for Android scenario_app runner. (flutte…

16bb22f

…r/engine#50937)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 070290bbae0a (12 revisions) flutter/flutter#144192

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

b28cfbbb4 Better filtering for Android scenario_app runner. (flutte…

bd9d843

…r/engine#50937)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 924d5db87d4f (13 revisions) flutter/flutter#144200

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

b28cfbbb4 Better filtering for Android scenario_app runner. (flutte…

e743197

…r/engine#50937)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 6965435111ef (19 revisions) flutter/flutter#144206

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

b28cfbbb4 Better filtering for Android scenario_app runner. (flutte…

912bf1a

…r/engine#50937)

engine-flutter-autoroll mentioned this pull request Feb 27, 2024

Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) flutter/flutter#144208

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024

b28cfbbb4 Better filtering for Android scenario_app runner. (flutte…

1d25433

…r/engine#50937)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better filtering for Android `scenario_app` runner. #50937

Better filtering for Android `scenario_app` runner. #50937

matanlurey commented Feb 24, 2024 •

edited

Loading

gaaclarke left a comment

gaaclarke Feb 26, 2024

matanlurey Feb 26, 2024

gaaclarke Feb 26, 2024

matanlurey Feb 26, 2024

gaaclarke Feb 26, 2024 •

edited

Loading

matanlurey Feb 26, 2024

gaaclarke Feb 26, 2024

matanlurey Feb 26, 2024

gaaclarke Feb 26, 2024 •

edited

Loading

matanlurey Feb 26, 2024

dnfield left a comment

dnfield commented Feb 26, 2024

Better filtering for Android scenario_app runner. #50937

Better filtering for Android scenario_app runner. #50937

Conversation

matanlurey commented Feb 24, 2024 • edited Loading

gaaclarke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaaclarke Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaaclarke Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnfield left a comment

Choose a reason for hiding this comment

dnfield commented Feb 26, 2024

Better filtering for Android `scenario_app` runner. #50937

Better filtering for Android `scenario_app` runner. #50937

matanlurey commented Feb 24, 2024 •

edited

Loading

gaaclarke Feb 26, 2024 •

edited

Loading

gaaclarke Feb 26, 2024 •

edited

Loading