Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] use specific format for bootstrap texture. #51082

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Feb 29, 2024

If we select a wide gamut format then 32 bits isn't enough to fill the texture.

@jonahwilliams jonahwilliams marked this pull request as ready for review February 29, 2024 21:09
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
@auto-submit auto-submit bot merged commit 6f80444 into flutter:main Feb 29, 2024
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 1, 2024
…144436)

flutter/engine@7e8fefe...6f80444

2024-02-29 [email protected] [Impeller] use specific format for bootstrap texture. (flutter/engine#51082)
2024-02-29 [email protected] [Impeller] remove warning about device transient depth+stencil. (flutter/engine#51033)
2024-02-29 [email protected] Refactor GL rendering to prepare for GTK4 (flutter/engine#50754)
2024-02-29 [email protected] Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077)
2024-02-29 [email protected] Revert "[macOS] Use CVDisplayLink to drive repaint (#49159)" (flutter/engine#51095)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants