Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[g3 roll] Revert "Remove unused drone_dimension field" #51214

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[g3 roll] Revert "Remove unused drone_dimension field" #51214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53aaea2
Revert "Remove unused drone_dimension field (#50893)"
XilaiZhang Mar 5, 2024
e10926b
Update .ci.yaml
XilaiZhang Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ targets:
properties:
release_build: "true"
config_name: linux_fuchsia
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment why we need this field, to avoid future removal mistakenly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added a comment

- os=Linux
dimensions:
kvm: "1"
# TODO(https://github.com/flutter/flutter/issues/138559): Re-enable/delete.
Expand Down Expand Up @@ -242,6 +246,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_arm_host_engine
drone_dimensions:
- os=Linux

- name: Linux linux_host_engine
recipe: engine_v2/engine_v2
Expand All @@ -254,6 +260,8 @@ targets:
[
{"dependency": "goldctl", "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"}
]
drone_dimensions:
- os=Linux

- name: Linux linux_host_desktop_engine
recipe: engine_v2/engine_v2
Expand All @@ -262,6 +270,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_host_desktop_engine
drone_dimensions:
- os=Linux

- name: Linux linux_android_aot_engine
recipe: engine_v2/engine_v2
Expand All @@ -270,6 +280,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_android_aot_engine
drone_dimensions:
- os=Linux

- name: Linux linux_android_debug_engine
recipe: engine_v2/engine_v2
Expand All @@ -278,6 +290,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_android_debug_engine
drone_dimensions:
- os=Linux

- name: Linux linux_license
recipe: engine_v2/builder
Expand All @@ -293,6 +307,8 @@ targets:
properties:
release_build: "true"
config_name: linux_web_engine
drone_dimensions:
- os=Linux
runIf:
- DEPS
- .ci.yaml
Expand Down Expand Up @@ -345,6 +361,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: mac_android_aot_engine
drone_dimensions:
- os=Linux

- name: Mac mac_clang_tidy
recipe: engine_v2/engine_v2
Expand Down Expand Up @@ -382,6 +400,8 @@ targets:
{
"sdk_version": "15a240d"
}
drone_dimensions:
- os=Mac-13

- name: Mac mac_unopt
recipe: engine_v2/engine_v2
Expand All @@ -401,6 +421,9 @@ targets:
{
"sdk_version": "15a240d"
}
drone_dimensions:
- os=Mac-13
- cpu=x86

- name: Mac impeller-cmake-example
bringup: true
Expand All @@ -417,6 +440,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: windows_android_aot_engine
drone_dimensions:
- os=Windows

- name: Windows windows_host_engine
recipe: engine_v2/engine_v2
Expand All @@ -425,6 +450,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: windows_host_engine
drone_dimensions:
- os=Windows

- name: Windows windows_arm_host_engine
recipe: engine_v2/engine_v2
Expand All @@ -435,6 +462,8 @@ targets:
properties:
add_recipes_cq: "true"
config_name: windows_arm_host_engine
drone_dimensions:
- os=Windows

- name: Windows windows_unopt
recipe: engine_v2/builder
Expand Down