Add et lint command #51238
Add et lint command #51238
Conversation
johnmccutchan
commented
Mar 6, 2024
johnmccutchan
commented
- Invokes lints for dart, python, c, and java.
- Captures all output of executions into an artifacts file (a json file).
- Runs lints concurrently.
- Cool status display while running.
- Tests.
johnmccutchan
force-pushed
the
et_lint
branch
2 times, most recently
from
951e075 to
f6b2ace
Compare
| // TODO(loic-sharma): Relax this restriction. | ||
| if (environment.platform.isWindows) { | ||
| environment.logger | ||
| .error('lint command is not supported on Windows (for now).'); |
There was a problem hiding this comment.
We should consider just adding a logger.fatal that:
- Throws
FatalError(...) - The root program catches it, displays it (in verbose mode, with a stack trace), and returns 1
| return 1; | ||
| } | ||
| final bool verbose = globalResults![verboseFlag] as bool; | ||
| final ProcessQueue pq = ProcessQueue(environment); |
There was a problem hiding this comment.
Zach has some similar classes for this in other parts of tools/, I'd check if we could either use it, or at least make sure we're not creating multiple things to do roughly the same thing (I'd look in tools/clang_tidy as a start).
There was a problem hiding this comment.
tools/clang_tidy uses https://pub.dev/documentation/process_runner/latest/process_runner/ProcessPool-class.html.
| } | ||
|
|
||
| /// Returns the dart-sdk/bin directory. | ||
| String findDartBinDirectory(Environment env) { |
There was a problem hiding this comment.
bin/et{.bat} invokes the engine tool entrypoint using the prebuilt dart binary under prebuilts, so you might also just use the parent directory of env.platform.resolvedExecutable for this.
johnmccutchan
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/51238, Failed to merge flutter/engine/51238 with Pull request flutter/engine/51238 could not be merged: Head branch is out of date. Review and try the merge again.. |
johnmccutchan
force-pushed
the
et_lint
branch
5 times, most recently
from
7be17cc to
f4e1b3c
Compare
…145067) flutter/engine@285b9fb...2871c26 2024-03-13 [email protected] Add et lint command (flutter/engine#51238) 2024-03-13 [email protected] Refactor `golden_tests_harvester`, throw when not `--dry-run`, add tests. (flutter/engine#51364) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
