[Impeller] started asserting golden test runner has fatal impeller validations

[gaaclarke]

fixes flutter/flutter#145017

This works by removing the conditional compilation for validation and turning them to be fatal in the test runner's main.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the CLA.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[gaaclarke]

I tried to use EXPECT_EXIT but I couldn't get it to stop killing the process.

[jonahwilliams]

You want to use EXPECT_DEATH?

That seems to work for me

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[matanlurey]

LGTM, but agree with expect_death if able.

[gaaclarke]

LGTM, but agree with expect_death if able.

I'll give that another try today.

[gaaclarke]

Yea looks like EXPECT_DEATH is unreliable in processes with more than one thread:

[ RUN      ] ValidationTest.IsFatal

[WARNING] ../../flutter/third_party/googletest/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 6 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.
[FATAL:flutter/impeller/base/validation.cc(57)] Break on 'ImpellerValidationBreak' to inspect point of failure: 
Abort trap: 6

I looked to see if I could make sure the test happens first, presumably before the other threads are spawned, and it doesn't look like there is a way to make that the case reliably with googletest.