[Impeller] dont clamp mipmap level to 0 with Vulkan textures. #51761
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Vulkan ToT
Metal/GLES
|
jonahwilliams
commented
Mar 28, 2024
| @@ -37,6 +37,7 @@ static vk::UniqueSampler CreateSampler( | |||
| sampler_info.addressModeW = address_mode_w; | |||
| sampler_info.borderColor = vk::BorderColor::eFloatTransparentBlack; | |||
| sampler_info.mipmapMode = mip_map; | |||
| sampler_info.maxLod = VK_LOD_CLAMP_NONE; | |||
There was a problem hiding this comment.
This defaults to 0 and clamps to the first mip level
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 29, 2024
…145946) flutter/engine@8b893cb...68aa9ba 2024-03-28 [email protected] [Impeller] dont clamp mipmap level to 0 with Vulkan textures. (flutter/engine#51761) 2024-03-28 [email protected] Add `et query tests` and `et test` commands (flutter/engine#51605) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mipmaps are not working at all right now with Vulkan. Opening without fix so we see goldens changing.