Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Remove "gclient sync" warning call during pre-rebase #52342

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Remove "gclient sync" warning call during pre-rebase #52342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3c05a
Remove "gclient sync" warning call during pre-rebase
jmagman Apr 23, 2024
e4d2dd6
remove unused import
jmagman Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tools/githooks/lib/src/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ const String _reset = '\x1B[0m';
/// Prints a reminder to stdout to run `gclient sync -D`. Uses colors when
/// stdout supports ANSI escape codes.
void printGclientSyncReminder(String command) {
if (command == 'pre-rebase') {
return;
}
final String prefix = io.stdout.supportsAnsiEscapes ? _redBoldUnderline : '';
final String postfix = io.stdout.supportsAnsiEscapes ? _reset : '';
io.stderr.writeln('$command: The engine source tree has been updated.');
Expand Down
3 changes: 0 additions & 3 deletions tools/githooks/lib/src/pre_rebase_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

import 'package:args/command_runner.dart';

import 'messages.dart';

/// The command that implements the pre-rebase githook
class PreRebaseCommand extends Command<bool> {
@override
Expand All @@ -16,7 +14,6 @@ class PreRebaseCommand extends Command<bool> {

@override
Future<bool> run() async {
printGclientSyncReminder(name);
// Returning false here will block the rebase.
return true;
}
Expand Down