This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[web] Set touch-action:none in embedded views. #53945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jul 16, 2024
...eb_ui/lib/src/engine/view_embedder/embedding_strategy/custom_element_embedding_strategy.dart
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2024
…ions) (#151889) Manual roll requested by [email protected] flutter/engine@18eefac...7e25796 2024-07-17 [email protected] Roll Skia from 1b0ddc1355ef to 7ebcb7ea944e (1 revision) (flutter/engine#53958) 2024-07-17 [email protected] Roll Skia from d19c61e55ea6 to 1b0ddc1355ef (1 revision) (flutter/engine#53957) 2024-07-17 [email protected] Roll Skia from 80dde3f27830 to d19c61e55ea6 (3 revisions) (flutter/engine#53956) 2024-07-17 [email protected] Roll Skia from 4c50b51875d4 to 80dde3f27830 (1 revision) (flutter/engine#53955) 2024-07-17 [email protected] [web] Set touch-action:none in embedded views. (flutter/engine#53945) 2024-07-17 [email protected] Roll Skia from d1478885de20 to 4c50b51875d4 (4 revisions) (flutter/engine#53953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Failed to create CP due to merge conflicts. |
ditman
added a commit
to ditman/flutter-engine
that referenced
this pull request
Jul 19, 2024
This PR adds `touch-action:none` to `flutter-view` elements, so the browser lets the flutter engine fully handle all touch gestures. This fix is more delicate than the first approach, which broke some merged taps when accessibility/semantics are enabled. ## Issues * Found while testing: flutter/flutter#130950 * "More correct" fix for: flutter#53647 ## Demos * Flutter scroll: https://dit-multiview-scroll.web.app * Semantics: https://dit-tests.web.app * Scrollable platform views: https://dit-multiview-tests.web.app [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…ions) (flutter#151889) Manual roll requested by [email protected] flutter/engine@18eefac...7e25796 2024-07-17 [email protected] Roll Skia from 1b0ddc1355ef to 7ebcb7ea944e (1 revision) (flutter/engine#53958) 2024-07-17 [email protected] Roll Skia from d19c61e55ea6 to 1b0ddc1355ef (1 revision) (flutter/engine#53957) 2024-07-17 [email protected] Roll Skia from 80dde3f27830 to d19c61e55ea6 (3 revisions) (flutter/engine#53956) 2024-07-17 [email protected] Roll Skia from 4c50b51875d4 to 80dde3f27830 (1 revision) (flutter/engine#53955) 2024-07-17 [email protected] [web] Set touch-action:none in embedded views. (flutter/engine#53945) 2024-07-17 [email protected] Roll Skia from d1478885de20 to 4c50b51875d4 (4 revisions) (flutter/engine#53953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
This PR adds `touch-action:none` to `flutter-view` elements, so the browser lets the flutter engine fully handle all touch gestures. This fix is more delicate than the first approach, which broke some merged taps when accessibility/semantics are enabled. ## Issues * Found while testing: flutter/flutter#130950 * "More correct" fix for: #53647 ## Demos * Flutter scroll: https://dit-multiview-scroll.web.app * Semantics: https://dit-tests.web.app * Scrollable platform views: https://dit-multiview-tests.web.app [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* --- ### Cherry-pick of #53945 * Fixes: flutter/flutter#152047
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ions) (flutter#151889) Manual roll requested by [email protected] flutter/engine@18eefac...7e25796 2024-07-17 [email protected] Roll Skia from 1b0ddc1355ef to 7ebcb7ea944e (1 revision) (flutter/engine#53958) 2024-07-17 [email protected] Roll Skia from d19c61e55ea6 to 1b0ddc1355ef (1 revision) (flutter/engine#53957) 2024-07-17 [email protected] Roll Skia from 80dde3f27830 to d19c61e55ea6 (3 revisions) (flutter/engine#53956) 2024-07-17 [email protected] Roll Skia from 4c50b51875d4 to 80dde3f27830 (1 revision) (flutter/engine#53955) 2024-07-17 [email protected] [web] Set touch-action:none in embedded views. (flutter/engine#53945) 2024-07-17 [email protected] Roll Skia from d1478885de20 to 4c50b51875d4 (4 revisions) (flutter/engine#53953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
touch-action:nonetoflutter-viewelements, so the browser lets the flutter engine fully handle all touch gestures.This fix is more delicate than the first approach, which broke some merged taps when accessibility/semantics are enabled.
Issues
Demos
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.