[skwasm] use temporary RawPaint objects #54917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
force-pushed
the
skwasm-paint-dispose
branch
from
4b15d56 to
5e80e38
Compare
eyebrowsoffire
approved these changes
Sep 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2024
jonahwilliams
added
the
revert
|
A reason for requesting a revert of flutter/engine/54917 could |
auto-submit
bot
removed
the
revert
|
reason for revert: failing on framework -> engine roll https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_skwasm_tests_7_last/10571/overview |
jonahwilliams
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 7, 2024
This reverts commit 0fad460.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Sep 7, 2024
Reverts: #54917 Initiated by: jonahwilliams Reason for reverting: failing on framework -> engine roll https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_skwasm_tests_7_last/10571/overview Original PR Author: yjbanov Reviewed By: {eyebrowsoffire} This change reverts the following previous change: Same as #54818, but for Skwasm. Addresses the `Paint` issue in flutter/flutter#153678 in Skwasm
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2024
…154764) flutter/engine@419fb8c...b9f9015 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917)" (flutter/engine#55018) 2024-09-06 [email protected] [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006) 2024-09-06 [email protected] Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014) 2024-09-06 [email protected] [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996) 2024-09-06 [email protected] [skwasm] use temporary RawPaint objects (flutter/engine#54917) 2024-09-06 [email protected] [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982) 2024-09-06 [email protected] Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013) 2024-09-06 [email protected] [Impeller] opt into exp canvas. (flutter/engine#54913) 2024-09-06 [email protected] Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008) 2024-09-06 [email protected] [impeller] fake image for fake tests. (flutter/engine#54974) 2024-09-06 [email protected] Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001) 2024-09-06 [email protected] Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2024
…visions) (#154764)" (#154765) Reverts: #154764 Initiated by: jonahwilliams Reason for reverting: failing post submit on mac module test. Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@419fb8c...b9f9015 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917)" (flutter/engine#55018) 2024-09-06 [email protected] [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006) 2024-09-06 [email protected] Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014) 2024-09-06 [email protected] [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996) 2024-09-06 [email protected] [skwasm] use temporary RawPaint objects (flutter/engine#54917) 2024-09-06 [email protected] [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982) 2024-09-06 [email protected] Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013) 2024-09-06 [email protected] [Impeller] opt into exp canvas. (flutter/engine#54913) 2024-09-06 [email protected] Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008) 2024-09-06 [email protected] [impeller] fake image for fake tests. (flutter/engine#54974) 2024-09-06 [email protected] Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001) 2024-09-06 [email protected] Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2024
…154769) flutter/engine@419fb8c...7bf1169 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] reland: always post tasks for platform channel responses. (#55006)" (flutter/engine#55022) 2024-09-07 [email protected] Turn off software rendering in iOS scenario golden tests (flutter/engine#55016) 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917)" (flutter/engine#55018) 2024-09-06 [email protected] [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006) 2024-09-06 [email protected] Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014) 2024-09-06 [email protected] [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996) 2024-09-06 [email protected] [skwasm] use temporary RawPaint objects (flutter/engine#54917) 2024-09-06 [email protected] [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982) 2024-09-06 [email protected] Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013) 2024-09-06 [email protected] [Impeller] opt into exp canvas. (flutter/engine#54913) 2024-09-06 [email protected] Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008) 2024-09-06 [email protected] [impeller] fake image for fake tests. (flutter/engine#54974) 2024-09-06 [email protected] Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001) 2024-09-06 [email protected] Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Relands #54917. The change is the same as before, except now the native resources for `SkwasmColorFilter` and `SkwasmImageFilter` classes are no longer GC'd. Instead, we use manually managed native handles (vended and scoped by `withRawColorFilter` and `withRawImageFilter`). The bug in the previous PR was that filter objects were disposed with the paint while the framework continued holding onto them. When GC kicked the finalization registry, it attempted to double-free the filters.
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
Same as flutter#54818, but for Skwasm. Addresses the `Paint` issue in flutter/flutter#153678 in Skwasm
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
…utter#55018) Reverts: flutter#54917 Initiated by: jonahwilliams Reason for reverting: failing on framework -> engine roll https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_skwasm_tests_7_last/10571/overview Original PR Author: yjbanov Reviewed By: {eyebrowsoffire} This change reverts the following previous change: Same as flutter#54818, but for Skwasm. Addresses the `Paint` issue in flutter/flutter#153678 in Skwasm
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
…55035) Relands flutter#54917. The change is the same as before, except now the native resources for `SkwasmColorFilter` and `SkwasmImageFilter` classes are no longer GC'd. Instead, we use manually managed native handles (vended and scoped by `withRawColorFilter` and `withRawImageFilter`). The bug in the previous PR was that filter objects were disposed with the paint while the framework continued holding onto them. When GC kicked the finalization registry, it attempted to double-free the filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #54818, but for Skwasm.
Addresses the
Paintissue in flutter/flutter#153678 in Skwasm