Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "IOS Platform view transform/clipping (#9075)" and fix the breakage. #9483

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

cyanglaz
Copy link
Contributor

Recommitting #9075
Fix for the last PR breaking the host test.

@cyanglaz cyanglaz requested a review from cbracken June 25, 2019 18:39
@chinmaygarde
Copy link
Member

chinmaygarde commented Jun 25, 2019

Please rename the commit message to say "Reland foo" and get rid of the extra PR numbers in the same before landing.

@cyanglaz cyanglaz changed the title Revert "Revert "IOS Platform view transform/clipping (#9075)" (#9480)" and fix the breakage. Reland "IOS Platform view transform/clipping (#9075)" and fix the breakage. Jun 25, 2019
@cyanglaz cyanglaz merged commit aa9b3a1 into flutter:master Jun 25, 2019
@cyanglaz cyanglaz deleted the revert branch June 25, 2019 22:29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 26, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 26, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 26, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jun 26, 2019
flutter/engine@3f4f606...238fc0f

git log 3f4f606..238fc0f --no-merges --oneline
238fc0f Roll src/third_party/skia 9dbbf887cee1..9acfb33ad8c6 (5 commits) (flutter/engine#9505)
e4ad3a2 Roll src/third_party/skia 2c1662e24da7..9dbbf887cee1 (6 commits) (flutter/engine#9502)
d85599f Roll src/third_party/skia 4f35817f3c91..2c1662e24da7 (3 commits) (flutter/engine#9500)
9190a22 Roll src/third_party/skia a7016ae7f03d..4f35817f3c91 (2 commits) (flutter/engine#9499)
2c8255f Roll src/third_party/skia 01cb2a422884..a7016ae7f03d (5 commits) (flutter/engine#9497)
da82361 Purge caches on low memory on iOS (flutter/engine#9491)
3122ecc Roll src/third_party/skia 0c4fbf1bbb93..01cb2a422884 (2 commits) (flutter/engine#9496)
2f1d4f0 fix build breakage on PlatformViews.mm (flutter/engine#9495)
1ab99fb fix a bug where the platform view's transform is not reset before set frame (flutter/engine#9490)
aa9b3a1 Reland "IOS Platform view transform/clipping (#9075)" and fix the breakage. (flutter/engine#9483)
d90573a Roll src/third_party/skia 69881fb0b5fb..0c4fbf1bbb93 (5 commits) (flutter/engine#9487)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@3f4f606...238fc0f

git log 3f4f606..238fc0f --no-merges --oneline
238fc0f Roll src/third_party/skia 9dbbf887cee1..9acfb33ad8c6 (5 commits) (flutter/engine#9505)
e4ad3a2 Roll src/third_party/skia 2c1662e24da7..9dbbf887cee1 (6 commits) (flutter/engine#9502)
d85599f Roll src/third_party/skia 4f35817f3c91..2c1662e24da7 (3 commits) (flutter/engine#9500)
9190a22 Roll src/third_party/skia a7016ae7f03d..4f35817f3c91 (2 commits) (flutter/engine#9499)
2c8255f Roll src/third_party/skia 01cb2a422884..a7016ae7f03d (5 commits) (flutter/engine#9497)
da82361 Purge caches on low memory on iOS (flutter/engine#9491)
3122ecc Roll src/third_party/skia 0c4fbf1bbb93..01cb2a422884 (2 commits) (flutter/engine#9496)
2f1d4f0 fix build breakage on PlatformViews.mm (flutter/engine#9495)
1ab99fb fix a bug where the platform view&flutter#39;s transform is not reset before set frame (flutter/engine#9490)
aa9b3a1 Reland &flutter#34;IOS Platform view transform/clipping (flutter#9075)&flutter#34; and fix the breakage. (flutter/engine#9483)
d90573a Roll src/third_party/skia 69881fb0b5fb..0c4fbf1bbb93 (5 commits) (flutter/engine#9487)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants