fix FlutterOverlayView doesn't remove from superview in some cases #9532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyanglaz Would you please take a look at this? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 27, 2019
flutter/engine@2bce4ed...6f7700f git log 2bce4ed..6f7700f --no-merges --oneline 6f7700f fix FlutterOverlayView doesn't remove from superview in some cases (flutter/engine#9532) f3cc375 Roll fuchsia/sdk/core/mac-amd64 from XT8hP4vbTcjWCQU7H_kwgDtIt2lXCWVgJkMNU252lZ8C to dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC (flutter/engine#9538) bc85f73 Roll fuchsia/sdk/core/linux-amd64 from L_ORUWXyDEC29pSiSyKIwGqcFMQFsV91E3h_wPbUIUkC to SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C (flutter/engine#9537) bf3a310 Roll fuchsia/sdk/core/mac-amd64 from Emw56Db0zg6Cnvgo7myIDZX0Lq-A6DFwEJHiPnr8K38C to XT8hP4vbTcjWCQU7H_kwgDtIt2lXCWVgJkMNU252lZ8C (flutter/engine#9531) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@2bce4ed...6f7700f git log 2bce4ed..6f7700f --no-merges --oneline 6f7700f fix FlutterOverlayView doesn&flutter#39;t remove from superview in some cases (flutter/engine#9532) f3cc375 Roll fuchsia/sdk/core/mac-amd64 from XT8hP4vbTcjWCQU7H_kwgDtIt2lXCWVgJkMNU252lZ8C to dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC (flutter/engine#9538) bc85f73 Roll fuchsia/sdk/core/linux-amd64 from L_ORUWXyDEC29pSiSyKIwGqcFMQFsV91E3h_wPbUIUkC to SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C (flutter/engine#9537) bf3a310 Roll fuchsia/sdk/core/mac-amd64 from Emw56Db0zg6Cnvgo7myIDZX0Lq-A6DFwEJHiPnr8K38C to XT8hP4vbTcjWCQU7H_kwgDtIt2lXCWVgJkMNU252lZ8C (flutter/engine#9531) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Problem
flutter/flutter#35177
2.Demo
https://github.com/Qxyat/Flutter-demo/tree/master/platform_view_demo
3.Solution
The 'views_to_dispose_' cache the view removed in 'OnDispose'，and the overlays_ attach to that 'viewId' should also remove from superview.