Document various classes in //flutter/shell/common. #9591

chinmaygarde · 2019-06-29T00:19:38Z

This patch contains documentation for Shell, PlatformView, IsolateConfiguration & RunConfiguration.

cbracken · 2019-06-29T00:43:34Z

shell/common/isolate_configuration.h

+///             isolate are collected. The engine may ask the configuration to
+///             prepare multiple isolates. All subclasses of this class must be
+///             thread safe as the configuration may be created, collected and
+///             used on multiple thread. Usually these threads are engine or VM


nit: multiple threads

cbracken · 2019-06-29T00:43:48Z

shell/common/isolate_configuration.h

+///             thread safe as the configuration may be created, collected and
+///             used on multiple thread. Usually these threads are engine or VM
+///             managed so care must be taken to ensure that subclasses do not
+///             reference any thred local state.


thread local

cbracken · 2019-06-29T00:44:48Z

shell/common/isolate_configuration.h

 class IsolateConfiguration {
 public:
+  //----------------------------------------------------------------------------
+  /// @brief      Attempts to infer the isolate configuration from the settings


maybe: a |Settings| object?

cbracken · 2019-06-29T00:45:35Z

shell/common/isolate_configuration.h

  static std::unique_ptr<IsolateConfiguration> InferFromSettings(
      const Settings& settings,
      std::shared_ptr<AssetManager> asset_manager,
      fml::RefPtr<fml::TaskRunner> io_worker);

+  //----------------------------------------------------------------------------
+  /// @brief      Create an AOT isolate configuration using snapshot symbols


Here and below:
nit: Creates (use a third-person verb for consistency with above.

cbracken · 2019-06-29T00:46:06Z

shell/common/isolate_configuration.h

+  //----------------------------------------------------------------------------
+  /// @brief      Create a JIT isolate configuration using a list of futures to
+  ///             snapshots defining the ready isolate state. In environments
+  ///             where snapshot resolution in extremely expensive, embedders


nit: is extremely

cbracken · 2019-06-29T00:53:46Z

shell/common/isolate_configuration.h

  static std::unique_ptr<IsolateConfiguration> CreateForKernelList(
      std::vector<std::unique_ptr<const fml::Mapping>> kernel_pieces);

+  //----------------------------------------------------------------------------
+  /// @brief      Create an isolate configuration. This has no threading


nit: Creates

cbracken · 2019-06-29T00:53:55Z

shell/common/isolate_configuration.h

  IsolateConfiguration();

+  //----------------------------------------------------------------------------
+  /// @brief      Destroy an isolate configuration. This has no threading


nit: Destroys

cbracken · 2019-06-29T00:58:40Z

shell/common/isolate_configuration.h

+  /// @brief      When an isolate is created and sufficiently initialized to
+  ///             move it into the `DartIsolate::Phase::LibrariesSetup` phase,
+  ///             this method is invoked on the isolate to then move the isolate
+  ///             into the `DartIsolate::Phase::Ready` phase. Then isolate's


Not sure, but do you think it scans a little better with the clauses of the sentence reversed to put the action up front?

Moves the Isolate to the `DartIsolate::Phase::Ready` phase from the `DartIsolate::Phase::LibrariesSetup` phase. The isolate's main entrypoint is then invoked to move it into the...

I reworded it but then it was not clear who was making the move. Not sure.

cbracken · 2019-06-29T00:59:28Z

shell/common/isolate_configuration.h

  virtual ~IsolateConfiguration();

+  //----------------------------------------------------------------------------
+  /// @brief      When an isolate is created and sufficiently initialized to
+  ///             move it into the `DartIsolate::Phase::LibrariesSetup` phase,


Should these phases be in |pipe|s?

I think both work but since I have not wired up the generator yet, I am not sure.

cbracken · 2019-06-29T01:00:30Z

shell/common/platform_view.h

+///             platform view associated with that shell. This involves
+///             operations like settings up and tearing down the render surface,
+///             platform messages, interacting with accessibility features on
+///             the platform, input events, etc..


nit: etc. (one dot)

cbracken · 2019-06-29T01:03:16Z

shell/common/platform_view.h

+  //----------------------------------------------------------------------------
+  /// @brief      Creates a platform view with the specified delegate and task
+  ///             runner. The base class by itself does not do much but is
+  ///             suutable for use in test environments where full platform


nit: suitable

cbracken · 2019-06-29T01:07:40Z

shell/common/platform_view.h

+  ///             platform specific functions. However, they must call the base
+  ///             class method at some point in their implementation.
+  ///
+  /// @param[in]  flags  The fetures to enable in the accessibility tree.


nit: features

cbracken · 2019-06-29T01:12:38Z

shell/common/platform_view.h

  virtual void SetAccessibilityFeatures(int32_t flags);

+  //----------------------------------------------------------------------------
+  /// @brief      Used by the framework to tell the embedder to apply the
+  ///             specified semantics node updates.


The wording here feels unclear wrt the 'direction' the update is moving. Maybe something like:

Forwards updates to semantics nodes and custom accessibility actions actions to the platform-specific embedder. These updates originate in the framework.

or similar? I'm not particularly happy with my wording here either :P

Actually on re-reading, the directionality is clear as-is "Used by [the framework|embedders]" is sufficient.

cbracken · 2019-06-29T01:16:39Z

shell/common/platform_view.h

+  /// @brief      Returns a weak pointer to the platform view. Since the
+  ///             platform view may only be created, accessed and destroyed on
+  ///             the platform thread, any access to the platform view from a
+  ///             non-platform task runner need a weak pointer to the platform


nit: needs a weak pointer (or 'accesses' on the previous line)

cbracken · 2019-06-29T01:17:18Z

shell/common/platform_view.h

  virtual void OnPreEngineRestart() const;

+  //----------------------------------------------------------------------------
+  /// @brief      Sets a callback that gets executed when the rasterizer renders
+  ///             the next frame. Due to the asynchrnous nature of rendering in


asynchronous

cbracken · 2019-06-29T01:17:47Z

shell/common/platform_view.h

+  ///             first initialized. This callback may be used as a signal to
+  ///             remove that placeholder. The callback is executed on the
+  ///             render task runner and not the platform task runner. It is
+  ///             embedder responsibility to re-thread as necessary.


the embedder's

cbracken · 2019-06-29T01:18:18Z

shell/common/platform_view.h

  void SetNextFrameCallback(fml::closure closure);

+  //----------------------------------------------------------------------------
+  /// @brief      Dispatches a pointer events from the embedder to the


Dispatches pointer events

cbracken · 2019-06-29T01:20:46Z

shell/common/platform_view.h

+  ///
+  /// @see        RegisterTexture, MarkTextureFrameAvailable
+  ///
+  /// @param[in]  texture_id  The identifer of the texture to unregister. If


The identifier

cbracken · 2019-06-29T01:22:08Z

shell/common/run_configuration.h

 class RunConfiguration {
 public:
+  //----------------------------------------------------------------------------
+  /// @brief      Attempt to infer a run configuration from the settings object.


nit: Attempts

cbracken · 2019-06-29T01:22:41Z

shell/common/run_configuration.h

+  ///             will attempt to look for the VM and isolate snapshots in the
+  ///             assets directory (must be specified in settings). In AOT mode,
+  ///             it will attempt to look for known snapshot symbols in the
+  ///             currently currently loaded process. The entrypoint default to


The entrypoint defaults

cbracken · 2019-06-29T01:23:13Z

shell/common/run_configuration.h

+  ///                        snapshots happens on a worker thread instead of the
+  ///                        calling thread. Note that the work done to realize
+  ///                        the snapshots may occur after this call returns. It
+  ///                        is embedder responsibility to make sure the thread


is the embedder's

cbracken · 2019-06-29T01:25:22Z

shell/common/run_configuration.h

+  ///                        is embedder responsibility to make sure the thread
+  ///                        for the serial worker is kept alive for as long as
+  ///                        the shell of the engine this run configuration is
+  ///                        given to is alive.


I wonder if this would scan a little easier:

.. for the serial worker is kept alive for the lifetime of the shell associated with the engine that this run configuration is given to.

Done. It is still a bit hard to follow but accurate.

cbracken · 2019-06-29T01:25:40Z

shell/common/run_configuration.h

  static RunConfiguration InferFromSettings(
      const Settings& settings,
      fml::RefPtr<fml::TaskRunner> io_worker = nullptr);

+  //----------------------------------------------------------------------------
+  /// @brief      Creates an run configuration with only an isolate


a run configuration

cbracken · 2019-06-29T01:27:16Z

shell/common/run_configuration.h

+  ///             isolate in the engine. However, the engine will always reject
+  ///             an invalid run configration.
+  ///
+  /// @attention  A valid run configuration does no mean that the root isolate


does not mean

cbracken · 2019-06-29T01:28:05Z

shell/common/run_configuration.h

+  ///             will always be launched. It only indicates that the various
+  ///             snapshots are isolate snapshots and asset managers are present
+  ///             and accounted for. The validity of the snapshots will only be
+  ///             checked when the engine attempts to launch the isolate.


nit: maybe "the root isolate"?

…engine#9591)

flutter/engine@ffba2f6...7d3e722 git log ffba2f6..7d3e722 --no-merges --oneline 7d3e722 Roll buildroot to c5a493b25. (flutter/engine#9649) 8deeb77 make EmbeddedViewParams a unique ptr (flutter/engine#9640) 7862af5 Roll src/third_party/skia bd3d8d39b3e7..215ff3325230 (4 commits) (flutter/engine#9648) a9ee687 iOS PlatformView clip path (flutter/engine#9478) c19b53c Roll src/third_party/skia effee2065796..bd3d8d39b3e7 (1 commits) (flutter/engine#9647) aeaa5ed Roll src/third_party/skia 2ef826576819..effee2065796 (1 commits) (flutter/engine#9646) 1cc1f04 Roll src/third_party/skia f2c52efce52b..2ef826576819 (2 commits) (flutter/engine#9645) 1c295b2 Roll src/third_party/skia 9fb7fa537d93..f2c52efce52b (1 commits) (flutter/engine#9644) 56a3f41 Android Embedding Refactor PR31: Integrate platform views with the new embedding and the plugin shim. (flutter/engine#9206) 8ac7cbd Fix warning about settings unavailable GN arg build_glfw_shell (flutter/engine#9642) f665717 Roll src/third_party/skia 21a486d04ae0..9fb7fa537d93 (21 commits) (flutter/engine#9639) fd24007 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9638) 628b174 Fixes a plugin overwrite bug in the plugin shim system. (flutter/engine#9589) 345d350 Added Doxyfile. (flutter/engine#9632) 64b9eef Revert "Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (#9634)" (flutter/engine#9637) 45e1ad2 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9634) da6475e Roll fuchsia/sdk/core/mac-amd64 from TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC to byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC (flutter/engine#9629) bee12e6 Roll fuchsia/sdk/core/mac-amd64 from MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C to TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC (flutter/engine#9626) fea8fa6 Roll fuchsia/sdk/core/linux-amd64 from Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C to I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C (flutter/engine#9625) e7f8ca1 [all] add fuchsia.{net.NameLookup,posix.socket.Provider} (flutter/engine#9546) a72a999 Roll fuchsia/sdk/core/mac-amd64 from B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C to MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C (flutter/engine#9624) b3fe3e9 Fix a race in the embedder accessibility unit test (flutter/engine#9585) 55818f6 Roll fuchsia/sdk/core/linux-amd64 from xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC to Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C (flutter/engine#9623) 37a54f2 Roll fuchsia/sdk/core/linux-amd64 from O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC to xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC (flutter/engine#9622) 458a764 Roll fuchsia/sdk/core/mac-amd64 from neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC to B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C (flutter/engine#9621) 6e7b4ca Roll fuchsia/sdk/core/linux-amd64 from gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC to O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC (flutter/engine#9620) e4d354d Roll src/third_party/skia 161f47dfbf6a..21a486d04ae0 (2 commits) (flutter/engine#9619) 2802875 Roll fuchsia/sdk/core/mac-amd64 from tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC to neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC (flutter/engine#9618) 8e405c1 Roll fuchsia/sdk/core/mac-amd64 from UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC to tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC (flutter/engine#9615) 609a980 Fix uninitialized variables and put tests in flutter namespace. (flutter/engine#9613) 9807894 Roll fuchsia/sdk/core/linux-amd64 from ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC to gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC (flutter/engine#9612) 4e344e6 Wire up custom event loop interop for the GLFW embedder. (flutter/engine#9089) 54c6226 Roll fuchsia/sdk/core/mac-amd64 from gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C to UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC (flutter/engine#9611) c3f8cab Roll fuchsia/sdk/core/linux-amd64 from xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC to ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC (flutter/engine#9610) 6f1a748 Document various classes in //flutter/shell/common. (flutter/engine#9591) 4d36530 Roll fuchsia/sdk/core/mac-amd64 from 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C to gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C (flutter/engine#9609) cf084bd Roll fuchsia/sdk/core/linux-amd64 from XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC to xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC (flutter/engine#9607) 8d05400 disable mysterious failing tests (flutter/engine#9608) aa817a9 Roll fuchsia/sdk/core/mac-amd64 from DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC to 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C (flutter/engine#9606) 4e988e0 Roll fuchsia/sdk/core/linux-amd64 from jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC to XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC (flutter/engine#9605) 84ae36a Roll fuchsia/sdk/core/mac-amd64 from IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC to DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC (flutter/engine#9604) 7135c8d Roll fuchsia/sdk/core/mac-amd64 from qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC to IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC (flutter/engine#9602) 8f4df03 Roll fuchsia/sdk/core/linux-amd64 from Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC to jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC (flutter/engine#9601) 6c6a0d7 [trace clients] Remove fuchsia.tracelink.Registry (flutter/engine#9593) f931539 Roll fuchsia/sdk/core/mac-amd64 from UsrGfX7Fj96MljgqUFc_A-o_ufsa_FX3eaG14ZSDWMAC to qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC (flutter/engine#9600) ...

flutter/engine@ffba2f6...7d3e722 git log ffba2f6..7d3e722 --no-merges --oneline 7d3e722 Roll buildroot to c5a493b25. (flutter/engine#9649) 8deeb77 make EmbeddedViewParams a unique ptr (flutter/engine#9640) 7862af5 Roll src/third_party/skia bd3d8d39b3e7..215ff3325230 (4 commits) (flutter/engine#9648) a9ee687 iOS PlatformView clip path (flutter/engine#9478) c19b53c Roll src/third_party/skia effee2065796..bd3d8d39b3e7 (1 commits) (flutter/engine#9647) aeaa5ed Roll src/third_party/skia 2ef826576819..effee2065796 (1 commits) (flutter/engine#9646) 1cc1f04 Roll src/third_party/skia f2c52efce52b..2ef826576819 (2 commits) (flutter/engine#9645) 1c295b2 Roll src/third_party/skia 9fb7fa537d93..f2c52efce52b (1 commits) (flutter/engine#9644) 56a3f41 Android Embedding Refactor PR31: Integrate platform views with the new embedding and the plugin shim. (flutter/engine#9206) 8ac7cbd Fix warning about settings unavailable GN arg build_glfw_shell (flutter/engine#9642) f665717 Roll src/third_party/skia 21a486d04ae0..9fb7fa537d93 (21 commits) (flutter/engine#9639) fd24007 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9638) 628b174 Fixes a plugin overwrite bug in the plugin shim system. (flutter/engine#9589) 345d350 Added Doxyfile. (flutter/engine#9632) 64b9eef Revert "Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter#9634)" (flutter/engine#9637) 45e1ad2 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9634) da6475e Roll fuchsia/sdk/core/mac-amd64 from TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC to byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC (flutter/engine#9629) bee12e6 Roll fuchsia/sdk/core/mac-amd64 from MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C to TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC (flutter/engine#9626) fea8fa6 Roll fuchsia/sdk/core/linux-amd64 from Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C to I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C (flutter/engine#9625) e7f8ca1 [all] add fuchsia.{net.NameLookup,posix.socket.Provider} (flutter/engine#9546) a72a999 Roll fuchsia/sdk/core/mac-amd64 from B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C to MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C (flutter/engine#9624) b3fe3e9 Fix a race in the embedder accessibility unit test (flutter/engine#9585) 55818f6 Roll fuchsia/sdk/core/linux-amd64 from xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC to Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C (flutter/engine#9623) 37a54f2 Roll fuchsia/sdk/core/linux-amd64 from O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC to xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC (flutter/engine#9622) 458a764 Roll fuchsia/sdk/core/mac-amd64 from neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC to B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C (flutter/engine#9621) 6e7b4ca Roll fuchsia/sdk/core/linux-amd64 from gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC to O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC (flutter/engine#9620) e4d354d Roll src/third_party/skia 161f47dfbf6a..21a486d04ae0 (2 commits) (flutter/engine#9619) 2802875 Roll fuchsia/sdk/core/mac-amd64 from tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC to neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC (flutter/engine#9618) 8e405c1 Roll fuchsia/sdk/core/mac-amd64 from UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC to tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC (flutter/engine#9615) 609a980 Fix uninitialized variables and put tests in flutter namespace. (flutter/engine#9613) 9807894 Roll fuchsia/sdk/core/linux-amd64 from ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC to gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC (flutter/engine#9612) 4e344e6 Wire up custom event loop interop for the GLFW embedder. (flutter/engine#9089) 54c6226 Roll fuchsia/sdk/core/mac-amd64 from gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C to UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC (flutter/engine#9611) c3f8cab Roll fuchsia/sdk/core/linux-amd64 from xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC to ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC (flutter/engine#9610) 6f1a748 Document various classes in //flutter/shell/common. (flutter/engine#9591) 4d36530 Roll fuchsia/sdk/core/mac-amd64 from 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C to gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C (flutter/engine#9609) cf084bd Roll fuchsia/sdk/core/linux-amd64 from XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC to xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC (flutter/engine#9607) 8d05400 disable mysterious failing tests (flutter/engine#9608) aa817a9 Roll fuchsia/sdk/core/mac-amd64 from DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC to 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C (flutter/engine#9606) 4e988e0 Roll fuchsia/sdk/core/linux-amd64 from jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC to XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC (flutter/engine#9605) 84ae36a Roll fuchsia/sdk/core/mac-amd64 from IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC to DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC (flutter/engine#9604) 7135c8d Roll fuchsia/sdk/core/mac-amd64 from qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC to IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC (flutter/engine#9602) 8f4df03 Roll fuchsia/sdk/core/linux-amd64 from Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC to jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC (flutter/engine#9601) 6c6a0d7 [trace clients] Remove fuchsia.tracelink.Registry (flutter/engine#9593) f931539 Roll fuchsia/sdk/core/mac-amd64 from UsrGfX7Fj96MljgqUFc_A-o_ufsa_FX3eaG14ZSDWMAC to qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC (flutter/engine#9600) ...

flutter/engine@ffba2f6...7d3e722 git log ffba2f6..7d3e722 --no-merges --oneline 7d3e722 Roll buildroot to c5a493b25. (flutter/engine#9649) 8deeb77 make EmbeddedViewParams a unique ptr (flutter/engine#9640) 7862af5 Roll src/third_party/skia bd3d8d39b3e7..215ff3325230 (4 commits) (flutter/engine#9648) a9ee687 iOS PlatformView clip path (flutter/engine#9478) c19b53c Roll src/third_party/skia effee2065796..bd3d8d39b3e7 (1 commits) (flutter/engine#9647) aeaa5ed Roll src/third_party/skia 2ef826576819..effee2065796 (1 commits) (flutter/engine#9646) 1cc1f04 Roll src/third_party/skia f2c52efce52b..2ef826576819 (2 commits) (flutter/engine#9645) 1c295b2 Roll src/third_party/skia 9fb7fa537d93..f2c52efce52b (1 commits) (flutter/engine#9644) 56a3f41 Android Embedding Refactor PR31: Integrate platform views with the new embedding and the plugin shim. (flutter/engine#9206) 8ac7cbd Fix warning about settings unavailable GN arg build_glfw_shell (flutter/engine#9642) f665717 Roll src/third_party/skia 21a486d04ae0..9fb7fa537d93 (21 commits) (flutter/engine#9639) fd24007 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9638) 628b174 Fixes a plugin overwrite bug in the plugin shim system. (flutter/engine#9589) 345d350 Added Doxyfile. (flutter/engine#9632) 64b9eef Revert &flutter#34;Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter#9634)&flutter#34; (flutter/engine#9637) 45e1ad2 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9634) da6475e Roll fuchsia/sdk/core/mac-amd64 from TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC to byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC (flutter/engine#9629) bee12e6 Roll fuchsia/sdk/core/mac-amd64 from MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C to TRwIGIJLuznLNQzJk17zfboJrkErpe1XvGr0njCwemoC (flutter/engine#9626) fea8fa6 Roll fuchsia/sdk/core/linux-amd64 from Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C to I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C (flutter/engine#9625) e7f8ca1 [all] add fuchsia.{net.NameLookup,posix.socket.Provider} (flutter/engine#9546) a72a999 Roll fuchsia/sdk/core/mac-amd64 from B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C to MBS_xxNZ_O32DxW1bhOeJisJqYG9JY_FAtSa3ZYupg4C (flutter/engine#9624) b3fe3e9 Fix a race in the embedder accessibility unit test (flutter/engine#9585) 55818f6 Roll fuchsia/sdk/core/linux-amd64 from xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC to Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C (flutter/engine#9623) 37a54f2 Roll fuchsia/sdk/core/linux-amd64 from O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC to xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC (flutter/engine#9622) 458a764 Roll fuchsia/sdk/core/mac-amd64 from neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC to B-JzM_H7hG5kOIRFjmUqI3uWBAV7no8BnCTknbd2wQ4C (flutter/engine#9621) 6e7b4ca Roll fuchsia/sdk/core/linux-amd64 from gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC to O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC (flutter/engine#9620) e4d354d Roll src/third_party/skia 161f47dfbf6a..21a486d04ae0 (2 commits) (flutter/engine#9619) 2802875 Roll fuchsia/sdk/core/mac-amd64 from tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC to neDu8hWotIrKCQkxz1ScSJC4NoBva1_YVszr6wMbcZQC (flutter/engine#9618) 8e405c1 Roll fuchsia/sdk/core/mac-amd64 from UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC to tPyg8rqV40gsoXEhDf7VskccnbJGCh4_bZp71YOUinEC (flutter/engine#9615) 609a980 Fix uninitialized variables and put tests in flutter namespace. (flutter/engine#9613) 9807894 Roll fuchsia/sdk/core/linux-amd64 from ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC to gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC (flutter/engine#9612) 4e344e6 Wire up custom event loop interop for the GLFW embedder. (flutter/engine#9089) 54c6226 Roll fuchsia/sdk/core/mac-amd64 from gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C to UkCx2sMZsCM-w9nEuQC2TRfnJ7wjJCxsCxSDEx2uPegC (flutter/engine#9611) c3f8cab Roll fuchsia/sdk/core/linux-amd64 from xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC to ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC (flutter/engine#9610) 6f1a748 Document various classes in //flutter/shell/common. (flutter/engine#9591) 4d36530 Roll fuchsia/sdk/core/mac-amd64 from 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C to gyWAjP3BPfhpvHOOwaTusfA8JaGcY_UzjpoIGQnA_W0C (flutter/engine#9609) cf084bd Roll fuchsia/sdk/core/linux-amd64 from XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC to xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC (flutter/engine#9607) 8d05400 disable mysterious failing tests (flutter/engine#9608) aa817a9 Roll fuchsia/sdk/core/mac-amd64 from DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC to 4PD6FCl4NvKCavA0AVsdKtZPB3G5K72KprkEH0mr064C (flutter/engine#9606) 4e988e0 Roll fuchsia/sdk/core/linux-amd64 from jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC to XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC (flutter/engine#9605) 84ae36a Roll fuchsia/sdk/core/mac-amd64 from IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC to DeTFBSaxMBfZpfK0c7CifGpJbJLOrs3WtuCOaINwmrwC (flutter/engine#9604) 7135c8d Roll fuchsia/sdk/core/mac-amd64 from qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC to IMr36r3rRLs1G7T5OtCudVMoWjPcjRbYGgyDg7LSxPwC (flutter/engine#9602) 8f4df03 Roll fuchsia/sdk/core/linux-amd64 from Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC to jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC (flutter/engine#9601) 6c6a0d7 [trace clients] Remove fuchsia.tracelink.Registry (flutter/engine#9593) f931539 Roll fuchsia/sdk/core/mac-amd64 from UsrGfX7Fj96MljgqUFc_A-o_ufsa_FX3eaG14ZSDWMAC to qcwCYvuT0PeU97HpvMVmC114EOKwfrk8PdFdZz_m6CIC (flutter/engine#9600) ...

Document various classes in //flutter/shell/common.

636c4bc

chinmaygarde requested review from cbracken, jason-simmons and gaaclarke June 29, 2019 00:19

googlebot added the cla: yes label Jun 29, 2019

cbracken reviewed Jun 29, 2019

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

4ccf466

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 1, 2019

Roll engine e96900df2f27..bee12e6f30b4 (52 commits) flutter/flutter#35384

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

42c72bf

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 1, 2019

Roll engine e96900df2f27..da6475eec0f4 (53 commits) flutter/flutter#35390

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

7c2cd6e

…engine#9591)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

fad8b9e

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 1, 2019

Roll engine 45b66b722e12..45e1ad27400d (48 commits) flutter/flutter#35422

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

e70ae5c

…engine#9591)

This was referenced Jul 1, 2019

Roll engine 45b66b722e12..64b9eef5c167 (49 commits) flutter/flutter#35427

Closed

Roll engine 45b66b722e12..345d350ab3da (50 commits) flutter/flutter#35430

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

724543b

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 1, 2019

Roll engine 45b66b722e12..628b174c9b63 (51 commits) flutter/flutter#35433

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

f3288fc

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 2, 2019

Roll engine 45b66b722e12..aeaa5edeec32 (58 commits) flutter/flutter#35462

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

9babc4d

…engine#9591)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

3822c62

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 2, 2019

Roll engine 45b66b722e12..c19b53cf28ce (59 commits) flutter/flutter#35463

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

81e9548

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 2, 2019

Roll engine 45b66b722e12..a9ee687ac9e1 (60 commits) flutter/flutter#35473

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

16a58e8

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 2, 2019

Roll engine 45b66b722e12..7862af54650b (61 commits) flutter/flutter#35474

Closed

a-siva mentioned this pull request Jul 2, 2019

Manual roll of engine ffba2f6...fd24007 flutter/flutter#35479

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

c07c53d

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 2, 2019

Roll engine ffba2f68d4e8..8deeb77f0557 (58 commits) flutter/flutter#35486

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2019

6f1a748 Document various classes in //flutter/shell/common. (flutter/…

d680d2e

…engine#9591)

engine-flutter-autoroll mentioned this pull request Jul 2, 2019

Roll engine ffba2f68d4e8..7d3e722349e7 (59 commits) flutter/flutter#35489

Merged

Document various classes in //flutter/shell/common. #9591

Document various classes in //flutter/shell/common. #9591

Conversation

chinmaygarde commented Jun 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cbracken Jun 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cbracken Jun 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cbracken Jun 29, 2019 •

edited

Loading

cbracken Jun 29, 2019 •

edited

Loading