Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raster now returns an enum rather than boolean #9661

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Raster now returns an enum rather than boolean #9661

merged 2 commits into from
Jul 4, 2019

Conversation

iskakaushik
Copy link
Contributor

This is part of a bigger change that will facilitate us
to act on this RasterStatus. The specific case is where
after pre-roll we might decide to want to merge the threads
and re-submit the frame -- RasterStatus::kResubmit can then
let us achieve this result.

Make compositor context propagate rater status
1a50492 
This is part of a bigger change that will facilitate us
to act on this `RasterStatus`. The specific case is where
after pre-roll we might decide to want to merge the threads
and re-submit the frame -- `RasterStatus::kResubmit` can then
let us achieve this result.
@iskakaushik iskakaushik requested review from chinmaygarde and amirh July 3, 2019 15:57
chinmaygarde
chinmaygarde approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please patch the typo in the commit message before committing. Thanks.

amirh
amirh approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: PR description is a little confusing as there's no new propagation happening here just replacing a bool with an enum

@iskakaushik iskakaushik changed the title Make compositor context propagate rater status Raster now returns an enum rather than boolean Jul 4, 2019
@iskakaushik iskakaushik merged commit 7f828dd into flutter:master Jul 4, 2019
@iskakaushik iskakaushik deleted the propagate-raster-status branch July 4, 2019 02:53
@iskakaushik
Copy link
Contributor Author

@chinmaygarde, @amirh addressed both your comments.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2019
@engine-flutter-autoroll
7f828dd Raster now returns an enum rather than boolean (flutter/engin…
ebf4908 
…e#9661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2019
@engine-flutter-autoroll
7f828dd Raster now returns an enum rather than boolean (flutter/engin…
85d7973 
…e#9661)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 4, 2019
@engine-flutter-autoroll
Roll engine 7d3e722..3c51a7b (20 commits) (#35572)
67237b9 
flutter/engine@7d3e722...3c51a7b

git log 7d3e722..3c51a7b --no-merges --oneline
3c51a7b Roll src/third_party/skia 11eb847a2080..857c9f955edb (2 commits) (flutter/engine#9676)
7f828dd Raster now returns an enum rather than boolean (flutter/engine#9661)
11b6afe  Roll src/third_party/dart 67ab3be10d...b5aeaa6796 (flutter/engine#9675)
3c4dbe2 Revert " Roll src/third_party/dart 67ab3be10d...43891316ca (#9670)" (flutter/engine#9673)
5e596f2  Roll src/third_party/dart 67ab3be10d...43891316ca (flutter/engine#9670)
46a2239 Roll src/third_party/skia 5b52c52141ac..11eb847a2080 (6 commits) (flutter/engine#9671)
b84f89b Allow embedders to add callbacks for responses to platform messages from the framework. (flutter/engine#9655)
8dac2e9 Begin separating macOS engine from view controller (flutter/engine#9654)
d3616c7 Roll src/third_party/skia 0e0113dcbd9a..5b52c52141ac (8 commits) (flutter/engine#9665)
cea2c36 Mutators Stack refactoring (flutter/engine#9663)
6a8782f Roll src/third_party/skia 93eeff578b08..0e0113dcbd9a (9 commits) (flutter/engine#9662)
791143f ExternalViewEmbedder can CancelFrame after pre-roll (flutter/engine#9660)
d637f29 External view embedder can tell if embedded views have mutated (flutter/engine#9653)
ceee3d7 Roll src/third_party/skia 38ae3f42fec1..93eeff578b08 (1 commits) (flutter/engine#9659)
d757290 Roll src/third_party/skia febc162c7898..38ae3f42fec1 (3 commits) (flutter/engine#9658)
58133ab Roll src/third_party/skia 3de5c6388142..febc162c7898 (2 commits) (flutter/engine#9657)
29342dd Roll src/third_party/skia 1e2cb444e0c1..3de5c6388142 (8 commits) (flutter/engine#9656)
b547356 Pipeline allows continuations that can produce to front (flutter/engine#9652)
8306ee6 Move the mutators stack handling to preroll (flutter/engine#9651)
511b9f2 Roll src/third_party/skia 215ff3325230..1e2cb444e0c1 (12 commits) (flutter/engine#9650)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@engine-flutter-autoroll @johnsonmh
Roll engine 7d3e722..3c51a7b (20 commits) (flutter#35572)
6496edf 
flutter/engine@7d3e722...3c51a7b

git log 7d3e722..3c51a7b --no-merges --oneline
3c51a7b Roll src/third_party/skia 11eb847a2080..857c9f955edb (2 commits) (flutter/engine#9676)
7f828dd Raster now returns an enum rather than boolean (flutter/engine#9661)
11b6afe  Roll src/third_party/dart 67ab3be10d...b5aeaa6796 (flutter/engine#9675)
3c4dbe2 Revert &flutter#34; Roll src/third_party/dart 67ab3be10d...43891316ca (flutter#9670)&flutter#34; (flutter/engine#9673)
5e596f2  Roll src/third_party/dart 67ab3be10d...43891316ca (flutter/engine#9670)
46a2239 Roll src/third_party/skia 5b52c52141ac..11eb847a2080 (6 commits) (flutter/engine#9671)
b84f89b Allow embedders to add callbacks for responses to platform messages from the framework. (flutter/engine#9655)
8dac2e9 Begin separating macOS engine from view controller (flutter/engine#9654)
d3616c7 Roll src/third_party/skia 0e0113dcbd9a..5b52c52141ac (8 commits) (flutter/engine#9665)
cea2c36 Mutators Stack refactoring (flutter/engine#9663)
6a8782f Roll src/third_party/skia 93eeff578b08..0e0113dcbd9a (9 commits) (flutter/engine#9662)
791143f ExternalViewEmbedder can CancelFrame after pre-roll (flutter/engine#9660)
d637f29 External view embedder can tell if embedded views have mutated (flutter/engine#9653)
ceee3d7 Roll src/third_party/skia 38ae3f42fec1..93eeff578b08 (1 commits) (flutter/engine#9659)
d757290 Roll src/third_party/skia febc162c7898..38ae3f42fec1 (3 commits) (flutter/engine#9658)
58133ab Roll src/third_party/skia 3de5c6388142..febc162c7898 (2 commits) (flutter/engine#9657)
29342dd Roll src/third_party/skia 1e2cb444e0c1..3de5c6388142 (8 commits) (flutter/engine#9656)
b547356 Pipeline allows continuations that can produce to front (flutter/engine#9652)
8306ee6 Move the mutators stack handling to preroll (flutter/engine#9651)
511b9f2 Roll src/third_party/skia 215ff3325230..1e2cb444e0c1 (12 commits) (flutter/engine#9650)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@amirh amirh amirh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iskakaushik @chinmaygarde @amirh @googlebot