SendPlatformMessage allow null message value #9781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses of SAFE_ACCESS - clang-format - providing default value of 0 for message_size
stuartmorgan
requested changes
Jul 11, 2019
- use explicit types
There was a problem hiding this comment.
Thanks for the patch! This looks good to me. But, please add a unit-test for this. Look at embedder_unittests.cc for PlatformMessagesCanBeSentWithoutResponseHandles. I think you can just copy paste that test and modify its contents to send a null message. Will help us regressing this in the future.
test null message value send with FlutterEngineSendPlatformMessage
|
Tree is red ATM. I will submit this when it goes green. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2019
flutter/engine@b25a1a4...66092d5 git log b25a1a4..66092d5 --no-merges --oneline 66092d5 SendPlatformMessage allow null message value (flutter/engine#9781) 69cacb5 Roll src/third_party/skia 0902c98825bf..a3e2996b0834 (8 commits) (flutter/engine#9846) 5c7c7c4 Roll fuchsia/sdk/core/mac-amd64 from IM-VITwgPUQ_cIbDBZHl9u_M_LPgWjLdnr7EM94udkoC to 94o0_NIcwi-V68SmUN4hU0fX5_JkMpPU5V8HaFvKWfYC (flutter/engine#9845) a0f5eb1 Roll src/third_party/skia c8e8e7061f1e..0902c98825bf (1 commits) (flutter/engine#9844) 1a571b0 Roll fuchsia/sdk/core/mac-amd64 from AsA8eYRT0BzzdU2_dr5qJJjqzVRO2wdUzp4eNyMfCmgC to IM-VITwgPUQ_cIbDBZHl9u_M_LPgWjLdnr7EM94udkoC (flutter/engine#9843) 64b6fc5 Roll fuchsia/sdk/core/mac-amd64 from t2vViX8EgEJz6fl_09azrb6Lr5qzlxA5I7NGADwIPmsC to AsA8eYRT0BzzdU2_dr5qJJjqzVRO2wdUzp4eNyMfCmgC (flutter/engine#9842) 7e8b4b5 Roll src/third_party/skia d830fd98a4ef..c8e8e7061f1e (4 commits) (flutter/engine#9841) 1574c49 Roll fuchsia/clang/mac-amd64 from Lc64-GTi4kihzkCnW8Vaa80TWTnMpZY0Fy6AqChmqvcC to USm3Qt9wen4bXoFF0T9Xt8NX-pyEfte2cTYi7geLAhQC (flutter/engine#9838) 4025cff Roll fuchsia/clang/linux-amd64 from oEsFSe99FkcDKVxZkAY0MKi6C-yYOan1m-QL45N33W8C to apsjZJ9ZIwlS08divc0QwxuNgIFeN4X-52mKR9d8qacC (flutter/engine#9839) 0a35db7 Roll src/third_party/skia 8ab6160c8149..d830fd98a4ef (3 commits) (flutter/engine#9836) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@b25a1a4...66092d5 git log b25a1a4..66092d5 --no-merges --oneline 66092d5 SendPlatformMessage allow null message value (flutter/engine#9781) 69cacb5 Roll src/third_party/skia 0902c98825bf..a3e2996b0834 (8 commits) (flutter/engine#9846) 5c7c7c4 Roll fuchsia/sdk/core/mac-amd64 from IM-VITwgPUQ_cIbDBZHl9u_M_LPgWjLdnr7EM94udkoC to 94o0_NIcwi-V68SmUN4hU0fX5_JkMpPU5V8HaFvKWfYC (flutter/engine#9845) a0f5eb1 Roll src/third_party/skia c8e8e7061f1e..0902c98825bf (1 commits) (flutter/engine#9844) 1a571b0 Roll fuchsia/sdk/core/mac-amd64 from AsA8eYRT0BzzdU2_dr5qJJjqzVRO2wdUzp4eNyMfCmgC to IM-VITwgPUQ_cIbDBZHl9u_M_LPgWjLdnr7EM94udkoC (flutter/engine#9843) 64b6fc5 Roll fuchsia/sdk/core/mac-amd64 from t2vViX8EgEJz6fl_09azrb6Lr5qzlxA5I7NGADwIPmsC to AsA8eYRT0BzzdU2_dr5qJJjqzVRO2wdUzp4eNyMfCmgC (flutter/engine#9842) 7e8b4b5 Roll src/third_party/skia d830fd98a4ef..c8e8e7061f1e (4 commits) (flutter/engine#9841) 1574c49 Roll fuchsia/clang/mac-amd64 from Lc64-GTi4kihzkCnW8Vaa80TWTnMpZY0Fy6AqChmqvcC to USm3Qt9wen4bXoFF0T9Xt8NX-pyEfte2cTYi7geLAhQC (flutter/engine#9838) 4025cff Roll fuchsia/clang/linux-amd64 from oEsFSe99FkcDKVxZkAY0MKi6C-yYOan1m-QL45N33W8C to apsjZJ9ZIwlS08divc0QwxuNgIFeN4X-52mKR9d8qacC (flutter/engine#9839) 0a35db7 Roll src/third_party/skia 8ab6160c8149..d830fd98a4ef (3 commits) (flutter/engine#9836) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: flutter/flutter#35434