Document FontFeature class #9808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 15, 2019
flutter/engine@76a91d3...3f27c57 git log 76a91d3..3f27c57 --no-merges --oneline 3f27c57 Roll fuchsia/sdk/core/mac-amd64 from pU_n3ahOhH6HJhE4vs5pUR8cg5U22TItP_Ds_N2OXPIC to qFyiJ56_6XZ5fjNssdCk_vOtBHg4YdWAPNeMIAf07-gC (flutter/engine#9830) eb4793a Revert "Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (#9826)" (flutter/engine#9829) 9c54621 bitcode (flutter/engine#9823) e105a89 Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter/engine#9826) 2e83c4a Roll fuchsia/sdk/core/linux-amd64 from ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC to IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC (flutter/engine#9827) 418fe5b Document FontFeature class (flutter/engine#9808) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@76a91d3...3f27c57 git log 76a91d3..3f27c57 --no-merges --oneline 3f27c57 Roll fuchsia/sdk/core/mac-amd64 from pU_n3ahOhH6HJhE4vs5pUR8cg5U22TItP_Ds_N2OXPIC to qFyiJ56_6XZ5fjNssdCk_vOtBHg4YdWAPNeMIAf07-gC (flutter/engine#9830) eb4793a Revert &flutter#34;Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter#9826)&flutter#34; (flutter/engine#9829) 9c54621 bitcode (flutter/engine#9823) e105a89 Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter/engine#9826) 2e83c4a Roll fuchsia/sdk/core/linux-amd64 from ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC to IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC (flutter/engine#9827) 418fe5b Document FontFeature class (flutter/engine#9808) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the typography sample from the Flutter 1.7 announcement blog. Please review with extra diligence, since this came from a product manager rather than a software engineer :)
I created this as an in-line sample rather than a snippet, because there's no easy way I could see to get the fonts into a sample app automatically.