Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing assignment to _allowHeadlessExecution #9855

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

franciscojma86
Copy link
Contributor

No description provided.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, thanks for the fix. Sometime soon I need to get unit tests on these APIs.

@franciscojma86 franciscojma86 merged commit cd321ee into flutter:master Jul 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 17, 2019
flutter/engine@eb248c2...8849d30

git log eb248c2..8849d30 --no-merges --oneline
8849d30 Add multi-line flag to semantics (flutter/engine#9850)
91e7a76 Roll src/third_party/dart 24725a8559..2b3336b51e (108 commits) (flutter/engine#9883)
3cd3e5e Roll fuchsia/sdk/core/mac-amd64 from x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C to PHtpiJGexJFgd7sgPTUbFphKES09fzotmtrO2kTHI08C (flutter/engine#9885)
cd321ee Assign missing headless execution variable (flutter/engine#9855)
3186ffe Roll src/third_party/skia 63fdd0191be0..e574f1e409aa (1 commits) (flutter/engine#9882)
9c9daa0 Roll fuchsia/sdk/core/mac-amd64 from f97PVV8BR3sa4rxRIc-xgvBxd6HYa8mKNp8zGmqqx-UC to x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C (flutter/engine#9881)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@eb248c2...8849d30

git log eb248c2..8849d30 --no-merges --oneline
8849d30 Add multi-line flag to semantics (flutter/engine#9850)
91e7a76 Roll src/third_party/dart 24725a8559..2b3336b51e (108 commits) (flutter/engine#9883)
3cd3e5e Roll fuchsia/sdk/core/mac-amd64 from x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C to PHtpiJGexJFgd7sgPTUbFphKES09fzotmtrO2kTHI08C (flutter/engine#9885)
cd321ee Assign missing headless execution variable (flutter/engine#9855)
3186ffe Roll src/third_party/skia 63fdd0191be0..e574f1e409aa (1 commits) (flutter/engine#9882)
9c9daa0 Roll fuchsia/sdk/core/mac-amd64 from f97PVV8BR3sa4rxRIc-xgvBxd6HYa8mKNp8zGmqqx-UC to x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C (flutter/engine#9881)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants