Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in generated xml Info.plist. #9867

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

gaaclarke
Copy link
Member

No description provided.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please land on red.

@gaaclarke gaaclarke merged commit dcac8a9 into flutter:master Jul 17, 2019
@gaaclarke
Copy link
Member Author

This fixed an xml typo from #9847

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 17, 2019
flutter/engine@e3e4b26...f336286

git log e3e4b26..f336286 --no-merges --oneline
f336286 Roll src/third_party/skia 947efe28de74..08ba11370342 (9 commits) (flutter/engine#9865)
dcac8a9 Fixed error in generated xml Info.plist. (flutter/engine#9867)
b7e5940  Started adding the engine hash to frameworks' Info.plist. (flutter/engine#9847)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@e3e4b26...f336286

git log e3e4b26..f336286 --no-merges --oneline
f336286 Roll src/third_party/skia 947efe28de74..08ba11370342 (9 commits) (flutter/engine#9865)
dcac8a9 Fixed error in generated xml Info.plist. (flutter/engine#9867)
b7e5940  Started adding the engine hash to frameworks&flutter#39; Info.plist. (flutter/engine#9847)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants