Split out lifecycle protocol #9922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlutterPlugin and make the API slightly closer to Android.
xster
reviewed
Jul 19, 2019
| @@ -18,107 +18,55 @@ NS_ASSUME_NONNULL_BEGIN | |||
| @protocol FlutterPluginRegistrar; | |||
| @protocol FlutterPluginRegistry; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Man GitHub diffing is pretty crappy. But I'm assuming you're just copy pasting stuff around.
There was a problem hiding this comment.
Yep, just moved around.
| * @param callback A callback for registering some set of plugins with a | ||
| * `FlutterPluginRegistry`. | ||
| #pragma mark - | ||
| /*************************************************************************************************** |
There was a problem hiding this comment.
Do these long lines do anything special with doxygen or something?
There was a problem hiding this comment.
Nope, they are ignored by doxygen. It's for the benefit of someone scrolling through the file to see breaks between the top level objects.
|
Still LGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 20, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 20, 2019
flutter/engine@5467f6f...9cf1356 git log 5467f6f..9cf1356 --no-merges --oneline 9cf1356 Added hasRenderedFirstFrame() to old FlutterView for Espresso (#36211). (flutter/engine#9939) 8d28215 Fix caching of Locale.toString (flutter/engine#9920) b1276ef Roll fuchsia/sdk/core/linux-amd64 from kKw24ZxMzd4Hx6mCaVBSxBJxx7wIKmxP8txe9Cp0dxIC to yCNSGMzcBMQzda_aHXqXWoW1cLSen0AL64orTFH-qHcC (flutter/engine#9955) 649e025 Removed PlatformViewsController if-statements from TextInputPlugin (#34286). (flutter/engine#9938) ede88d7 Roll src/third_party/skia aa861a1907a1..4a13119a60e2 (9 commits) (flutter/engine#9950) 48b1340 Fix the geometry test to reflect that OffsetBase comparison operators are a partial ordering (flutter/engine#9925) 971c3f2 Roll fuchsia/sdk/core/linux-amd64 from XG_fYb35A8mJpnMG_I9iBm7yHJyNZYZRgG69a88us_sC to kKw24ZxMzd4Hx6mCaVBSxBJxx7wIKmxP8txe9Cp0dxIC (flutter/engine#9947) 3d7f93a Removed logic from FlutterAppDelegate into FlutterPluginAppLifeCycleDelegate (flutter/engine#9893) 273f4cf Split out lifecycle protocol (flutter/engine#9922) f41be3e Roll src/third_party/skia 58d1f76fc008..aa861a1907a1 (7 commits) (flutter/engine#9946) 53f620f [platform view] do not make clipping view and interceptor view clipToBounds (flutter/engine#9937) a1faebb Roll fuchsia/sdk/core/linux-amd64 from IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC to XG_fYb35A8mJpnMG_I9iBm7yHJyNZYZRgG69a88us_sC (flutter/engine#9945) 309ad63 Roll src/third_party/skia 95528752e2bd..58d1f76fc008 (1 commits) (flutter/engine#9944) d852e8a Roll src/third_party/skia 19547c91b983..95528752e2bd (1 commits) (flutter/engine#9943) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@5467f6f...9cf1356 git log 5467f6f..9cf1356 --no-merges --oneline 9cf1356 Added hasRenderedFirstFrame() to old FlutterView for Espresso (flutter#36211). (flutter/engine#9939) 8d28215 Fix caching of Locale.toString (flutter/engine#9920) b1276ef Roll fuchsia/sdk/core/linux-amd64 from kKw24ZxMzd4Hx6mCaVBSxBJxx7wIKmxP8txe9Cp0dxIC to yCNSGMzcBMQzda_aHXqXWoW1cLSen0AL64orTFH-qHcC (flutter/engine#9955) 649e025 Removed PlatformViewsController if-statements from TextInputPlugin (flutter#34286). (flutter/engine#9938) ede88d7 Roll src/third_party/skia aa861a1907a1..4a13119a60e2 (9 commits) (flutter/engine#9950) 48b1340 Fix the geometry test to reflect that OffsetBase comparison operators are a partial ordering (flutter/engine#9925) 971c3f2 Roll fuchsia/sdk/core/linux-amd64 from XG_fYb35A8mJpnMG_I9iBm7yHJyNZYZRgG69a88us_sC to kKw24ZxMzd4Hx6mCaVBSxBJxx7wIKmxP8txe9Cp0dxIC (flutter/engine#9947) 3d7f93a Removed logic from FlutterAppDelegate into FlutterPluginAppLifeCycleDelegate (flutter/engine#9893) 273f4cf Split out lifecycle protocol (flutter/engine#9922) f41be3e Roll src/third_party/skia 58d1f76fc008..aa861a1907a1 (7 commits) (flutter/engine#9946) 53f620f [platform view] do not make clipping view and interceptor view clipToBounds (flutter/engine#9937) a1faebb Roll fuchsia/sdk/core/linux-amd64 from IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC to XG_fYb35A8mJpnMG_I9iBm7yHJyNZYZRgG69a88us_sC (flutter/engine#9945) 309ad63 Roll src/third_party/skia 95528752e2bd..58d1f76fc008 (1 commits) (flutter/engine#9944) d852e8a Roll src/third_party/skia 19547c91b983..95528752e2bd (1 commits) (flutter/engine#9943) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts iOS slightly more inline with Android without breaking current functionality. It is more "clean" too since this new protocol is a nice logical grouping and it makes FlutterPlugin more grokable.
Related issue: flutter/flutter#33071