Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: misleading exception message in font_subset test script #145412

Closed
selfisekai opened this issue Mar 19, 2024 · 1 comment · Fixed by flutter/engine#51492
Closed

engine: misleading exception message in font_subset test script #145412

selfisekai opened this issue Mar 19, 2024 · 1 comment · Fixed by flutter/engine#51492
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-engine Owned by Engine team

Comments

@selfisekai
Copy link
Contributor

flutter/engine#51492

font_subset tests previously were hardcoded to look for the binary in specific build variants, and got later changed (in flutter/engine#50327) to require an explicit variant as an argument

little nitpick: the exception message still hardcodes variants instead of naming the one being actually checked
@selfisekai selfisekai mentioned this issue Mar 19, 2024
Merged
8 tasks
@darshankawar darshankawar added in triage Presently being triaged by the triage team engine flutter/engine repository. See also e: labels. team-engine Owned by Engine team and removed in triage Presently being triaged by the triage team labels Mar 20, 2024
@jonahwilliams jonahwilliams added the P2 Important issues not at the top of the work list label Mar 25, 2024
auto-submit bot pushed a commit to flutter/engine that referenced this issue Mar 25, 2024
@selfisekai
font_subset tests: name correct variant in exception (#51492)
f8c79f9 
font_subset tests now respect `--variant`, but the exception message hasn't been changed

*List which issues are fixed by this PR. You must list at least one issue.*
closes flutter/flutter#145412

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label Mar 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-engine Owned by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

font_subset tests: name correct variant in exception selfisekai/flutter-engine
4 participants
@jonahwilliams @selfisekai @darshankawar @danagbemava-nc