Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute can cause a crash in release mode #49601

Closed
dnfield opened this issue Jan 28, 2020 · 2 comments
Closed

compute can cause a crash in release mode #49601

dnfield opened this issue Jan 28, 2020 · 2 comments
Assignees
@dnfield
Labels
c: crash Stack traces logged to the console c: regression It was better in the past than it is now framework flutter/packages/flutter repository. See also f: labels.

Comments

@dnfield
Copy link
Contributor

dnfield commented Jan 28, 2020

#49352 caused some function calls that were called with the string literal 'null' to be called with null. In particular, if an app calls compute in release mode with a null debug label, it will crash.
@dnfield dnfield self-assigned this Jan 28, 2020
@dnfield dnfield added framework flutter/packages/flutter repository. See also f: labels. c: crash Stack traces logged to the console c: regression It was better in the past than it is now ⚠ TODAY labels Jan 28, 2020
@dnfield dnfield mentioned this issue Jan 28, 2020
Merged
@jonahwilliams jonahwilliams mentioned this issue Jan 28, 2020
Closed
@a14n a14n mentioned this issue Jan 28, 2020
Merged
9 tasks
jason-simmons added a commit to jason-simmons/flutter that referenced this issue Jan 28, 2020
@jason-simmons
Provide a non-null default value for the compute debug label in relea…
3586d30 
…se mode

Timeline APIs require non-null operation labels.

See flutter#49601
@dnfield dnfield closed this as completed Jan 29, 2020
@dnfield
Copy link
Contributor Author

dnfield commented Jan 29, 2020

(This was fixed by #49602)

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dnfield dnfield

Labels
c: crash Stack traces logged to the console c: regression It was better in the past than it is now framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dnfield