[flutter_tools] pub roll #103220

christopherfujino · 2022-05-06T19:48:15Z

Pub roll that works around #102781

Fixes #102868.
Fixes #102159
Fixes #85035

This roll is needed to pick up critical upgrades to crypto and dwds

goderbauer

LGTM

Thank you!!

christopherfujino · 2022-05-06T20:45:57Z

Looks like I need fix analysis

christopherfujino · 2022-05-06T22:22:45Z

@goderbauer actually, can you help me with fixing analysis on the old flutter_gallery? package:url_launcher deprecated an API, and I'm not sure what to do about our use of forceSafariVC: false in the legacy API.

~/git/flutter/dev/integration_tests/flutter_gallery$ flutter analyze .
Analyzing flutter_gallery...

   info • 'launch' is deprecated and shouldn't be used. Use launchUrl instead •
          lib/gallery/about.dart:28:7 • deprecated_member_use
   info • 'launch' is deprecated and shouldn't be used. Use launchUrl instead •
          lib/gallery/app.dart:125:11 • deprecated_member_use
   info • 'canLaunch' is deprecated and shouldn't be used. Use canLaunchUrl instead •
          lib/gallery/demo.dart:73:15 • deprecated_member_use
   info • 'launch' is deprecated and shouldn't be used. Use launchUrl instead •
          lib/gallery/demo.dart:74:13 • deprecated_member_use
   info • 'launch' is deprecated and shouldn't be used. Use launchUrl instead •
          lib/gallery/demo.dart:233:24 • deprecated_member_use
   info • 'launch' is deprecated and shouldn't be used. Use launchUrl instead •
          lib/gallery/demo.dart:256:24 • deprecated_member_use
   info • 'launch' is deprecated and shouldn't be used. Use launchUrl instead •
          lib/gallery/updater.dart:40:7 • deprecated_member_use

christopherfujino · 2022-05-06T22:23:46Z

This test failure is a little puzzling:

00:36 +634 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/theme_data_test.dart: ThemeData can generate a dark colorScheme from colorSchemeSeed [E]                                           
  Expected: Color:<Color(0xff9ccaff)>
    Actual: Color:<Color(0xff9ecaff)>
  
  package:test_api                                    expect
  package:flutter_test/src/widget_tester.dart 455:16  expect
  test/material/theme_data_test.dart 249:5            main.<fn>

Edit: nvm, the hex is different, I'm bad at reading

christopherfujino · 2022-05-06T22:28:12Z

So it looks like bumping package:material_color_utilities caused breaking changes to our Linux framework_tests_libraries. @HansMuller should I just accept these changes?

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8814886108995385025/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/test_stdout

goderbauer · 2022-05-06T23:04:39Z

actually, can you help me with fixing analysis on the old flutter_gallery? package:url_launcher deprecated an API, and I'm not sure what to do about our use of forceSafariVC: false in the legacy API.

Can you cherry-pick this commit into your PR here: goderbauer@36bfa7c

goderbauer · 2022-05-06T23:11:13Z

So it looks like bumping package:material_color_utilities caused breaking changes to our Linux framework_tests_libraries. @HansMuller should I just accept these changes?

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8814886108995385025/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/test_stdout

@darrenaustin may also be able to help here.

darrenaustin · 2022-05-06T23:22:14Z

So it looks like bumping package:material_color_utilities caused breaking changes to our Linux framework_tests_libraries. @HansMuller should I just accept these changes?

I thought we had pinned the version of this library to avoid changes like this. It would appear that the palette generation algorithm may have changed, yielding slightly different colors. @guidezpl might know more, but for now can we not update this package version?

christopherfujino · 2022-05-09T02:29:58Z

So it looks like bumping package:material_color_utilities caused breaking changes to our Linux framework_tests_libraries. @HansMuller should I just accept these changes?

I thought we had pinned the version of this library to avoid changes like this. It would appear that the palette generation algorithm may have changed, yielding slightly different colors. @guidezpl might know more, but for now can we not update this package version?

Cool, will do.

guidezpl · 2022-05-09T09:17:49Z

Looping in @pennzht, is the slight change between 0.1.4. and 0.1.5 mentioned in #103220 (comment) expected?

annagrin · 2022-05-09T18:32:39Z

@christopherfujino I need to update dwds - could you please look at #103243, we probably need to merge some changes...

christopherfujino · 2022-05-09T18:39:11Z

@christopherfujino I need to update dwds - could you please look at #103243, we probably need to merge some changes...

@annagrin let me land this to fix the url_launcher compilation error, then i'll help you rebase your PR.

christopherfujino · 2022-05-09T18:45:57Z

@annagrin Never mind, looks like I'll have to patch in your changes to this PR :)

christopherfujino · 2022-05-09T19:32:24Z

Re-ran windows build_tests_1_3 because of #97160

annagrin · 2022-05-09T23:33:00Z

thank you @christopherfujino!

flutter-dashboard · 2022-05-09T23:38:39Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jmagman · 2022-05-09T23:49:35Z

Ran Mac_ios hot_mode_dev_cycle_macos_target__benchmark locally on pub-roll branch 661c465 and it passed:

Task result:
{
  "success": true,
  "data": {
    "hotReloadInitialDevFSSyncMilliseconds": 256,
    "hotRestartMillisecondsToFrame": 415,
    "hotReloadMillisecondsToFrame": 148,
    "hotReloadDevFSSyncMilliseconds": 19,
    "hotReloadFlutterReassembleMilliseconds": 127,
    "hotReloadVMReloadMilliseconds": 0,
    "hotReloadMillisecondsToFrameAfterChange": 299,
    "hotReloadDevFSSyncMillisecondsAfterChange": 70,
    "hotReloadFlutterReassembleMillisecondsAfterChange": 113,
    "hotReloadVMReloadMillisecondsAfterChange": 114,
    "hotReloadInitialDevFSSyncAfterRelaunchMilliseconds": 256,
    "hotReloadMillisecondsToFrameAfterMediumChange": 322,
    "hotReloadDevFSSyncMillisecondsAfterMediumChange": 42,
    "hotReloadFlutterReassembleMillisecondsAfterMediumChange": 167,
    "hotReloadVMReloadMillisecondsAfterMediumChange": 110,
    "hotReloadMillisecondsToFrameAfterLargeChange": 6680,
    "hotReloadDevFSSyncMillisecondsAfterLargeChange": 5498,
    "hotReloadFlutterReassembleMillisecondsAfterLargeChange": 426,
    "hotReloadVMReloadMillisecondsAfterLargeChange": 754
  },
  "detailFiles": [],
  "benchmarkScoreKeys": [
    "hotReloadInitialDevFSSyncMilliseconds",
    "hotRestartMillisecondsToFrame",
    "hotReloadMillisecondsToFrame",
    "hotReloadDevFSSyncMilliseconds",
    "hotReloadFlutterReassembleMilliseconds",
    "hotReloadVMReloadMilliseconds",
    "hotReloadMillisecondsToFrameAfterChange",
    "hotReloadDevFSSyncMillisecondsAfterChange",
    "hotReloadFlutterReassembleMillisecondsAfterChange",
    "hotReloadVMReloadMillisecondsAfterChange",
    "hotReloadInitialDevFSSyncAfterRelaunchMilliseconds",
    "hotReloadMillisecondsToFrameAfterMediumChange",
    "hotReloadDevFSSyncMillisecondsAfterMediumChange",
    "hotReloadFlutterReassembleMillisecondsAfterMediumChange",
    "hotReloadVMReloadMillisecondsAfterMediumChange",
    "hotReloadMillisecondsToFrameAfterLargeChange",
    "hotReloadDevFSSyncMillisecondsAfterLargeChange",
    "hotReloadFlutterReassembleMillisecondsAfterLargeChange",
    "hotReloadVMReloadMillisecondsAfterLargeChange"
  ],
  "reason": "success"
}

Hixie · 2022-05-10T00:20:27Z

text-exempt: rolling dependencies

christopherfujino · 2022-05-10T17:26:45Z

Landing this manually as the Mac_ios hot_mode_dev_cycle_macos_target__benchmark test was verified locally by Jenn and the test was pending because of #103369

pub roll

4071045

christopherfujino requested a review from goderbauer May 6, 2022 19:48

christopherfujino requested a review from Piinks as a code owner May 6, 2022 19:48

flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label May 6, 2022

goderbauer approved these changes May 6, 2022

View reviewed changes

goderbauer mentioned this pull request May 9, 2022

run flutter update-packages --force to Update all packages #103243

Closed

8 tasks

Migrate url_launcher

cb29aac

christopherfujino mentioned this pull request May 9, 2022

[flutter_tools] package:material_color_utilities pinned at 0.1.4 because of breaking changes #103357

Closed

christopherfujino added 2 commits May 9, 2022 11:47

pin material_color_utilities, pull in latest dwds

273361a

cp patch from annagrin/update-dwds

132e7de

empty

661c465

christopherfujino mentioned this pull request May 9, 2022

devicelab pre-submit test failed without link to logs #103369

Closed

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 9, 2022

annagrin mentioned this pull request May 10, 2022

[Web][Tool]: Flutter web debugging fails with DevHandler: Stopped debug service on Chrome enterprise #99157

Closed

christopherfujino mentioned this pull request May 10, 2022

[flutter_tools] Autoroll pub packages #102780

Closed

christopherfujino merged commit e8c01a8 into flutter:master May 10, 2022

christopherfujino deleted the pub-roll branch May 10, 2022 17:26

annagrin mentioned this pull request May 10, 2022

Fix issues discovered when using web server device in flutter tools dart-lang/webdev#1588

Merged

engine-flutter-autoroll mentioned this pull request May 10, 2022

Roll Flutter from 8c46968c620e to 222a93a7040f (2 revisions) flutter/packages#1870

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2022

e8c01a8 [flutter_tools] pub roll (flutter/flutter#103220)

a9795a2

engine-flutter-autoroll mentioned this pull request May 10, 2022

Roll Flutter from 4bed76757db7 to df7111a848cb (42 revisions) flutter/plugins#5696

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 10, 2022

e8c01a8 [flutter_tools] pub roll (flutter/flutter#103220)

d2e0817

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

e8c01a8 [flutter_tools] pub roll (flutter/flutter#103220)

7e85485

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

e8c01a8 [flutter_tools] pub roll (flutter/flutter#103220)

4136ac9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_tools] pub roll #103220

[flutter_tools] pub roll #103220

christopherfujino commented May 6, 2022 •

edited

Loading

goderbauer left a comment

christopherfujino commented May 6, 2022

christopherfujino commented May 6, 2022

christopherfujino commented May 6, 2022 •

edited

Loading

christopherfujino commented May 6, 2022 •

edited

Loading

goderbauer commented May 6, 2022

goderbauer commented May 6, 2022

darrenaustin commented May 6, 2022

christopherfujino commented May 9, 2022

guidezpl commented May 9, 2022

annagrin commented May 9, 2022

christopherfujino commented May 9, 2022

christopherfujino commented May 9, 2022 •

edited

Loading

christopherfujino commented May 9, 2022

annagrin commented May 9, 2022

flutter-dashboard bot commented May 9, 2022

jmagman commented May 9, 2022 •

edited

Loading

Hixie commented May 10, 2022

christopherfujino commented May 10, 2022

[flutter_tools] pub roll #103220

[flutter_tools] pub roll #103220

Conversation

christopherfujino commented May 6, 2022 • edited Loading

goderbauer left a comment

Choose a reason for hiding this comment

christopherfujino commented May 6, 2022

christopherfujino commented May 6, 2022

christopherfujino commented May 6, 2022 • edited Loading

christopherfujino commented May 6, 2022 • edited Loading

goderbauer commented May 6, 2022

goderbauer commented May 6, 2022

darrenaustin commented May 6, 2022

christopherfujino commented May 9, 2022

guidezpl commented May 9, 2022

annagrin commented May 9, 2022

christopherfujino commented May 9, 2022

christopherfujino commented May 9, 2022 • edited Loading

christopherfujino commented May 9, 2022

annagrin commented May 9, 2022

flutter-dashboard bot commented May 9, 2022

jmagman commented May 9, 2022 • edited Loading

Hixie commented May 10, 2022

christopherfujino commented May 10, 2022

christopherfujino commented May 6, 2022 •

edited

Loading

christopherfujino commented May 6, 2022 •

edited

Loading

christopherfujino commented May 6, 2022 •

edited

Loading

christopherfujino commented May 9, 2022 •

edited

Loading

jmagman commented May 9, 2022 •

edited

Loading