Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Bring up "complex_layout" devicelab, startup tests for x64 #110100

Merged
merged 7 commits into from
Aug 25, 2022

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Aug 23, 2022

Reason

The initial desktop integration tests are running now, but they need to be expanded beyond the initial gallery build test; filing this to make sure that planned work is captured in the issue tracker. This should be much more straightforward that getting the first one running was, since the bot work is all complete.

In particular we should ensure we are testing building a freshly created project to catch errors in template changes. (I haven't checked where that test lives on existing platforms; it may be a device lab test, which still needs desktop bring-up).

Related

fixes #110083

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 23, 2022
@a-wallen a-wallen changed the title Macos bringup complex startup [macOS] Bring up "complex_layout" devicelab, startup tests for x86 and arm64. Aug 23, 2022
@a-wallen a-wallen force-pushed the macos_bringup_complex_startup branch 3 times, most recently from 06f878f to 9e8c678 Compare August 24, 2022 23:02
@a-wallen a-wallen marked this pull request as ready for review August 25, 2022 00:35
@a-wallen a-wallen requested a review from keyonghan as a code owner August 25, 2022 00:35
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-wallen a-wallen force-pushed the macos_bringup_complex_startup branch from 9e8c678 to cea1d32 Compare August 25, 2022 16:15
@a-wallen a-wallen force-pushed the macos_bringup_complex_startup branch 2 times, most recently from ddaa1c9 to a55054f Compare August 25, 2022 17:29
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the title to just x64 for now since arm64 testing will depend on either (a) eliminating our reliance on x64 binaries under rosetta in our engine/tooling build products like gen_snapshot and libimobiledevice (b) getting rosetta on our machine images.

Of those, we're getting pushback on (b) and (a) is the better choice regardless.

@a-wallen a-wallen force-pushed the macos_bringup_complex_startup branch from a55054f to d1cd200 Compare August 25, 2022 19:55
@a-wallen a-wallen changed the title [macOS] Bring up "complex_layout" devicelab, startup tests for x86 and arm64. [macOS] Bring up "complex_layout" devicelab, startup tests for x86. Aug 25, 2022
@a-wallen a-wallen force-pushed the macos_bringup_complex_startup branch 2 times, most recently from edddc76 to 4517d34 Compare August 25, 2022 21:04
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@auto-submit auto-submit bot merged commit 27bfc51 into flutter:master Aug 25, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Bring up "complex_layout" devicelab, startup tests for x86.
4 participants