-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Bring up "complex_layout" devicelab, startup tests for x64 #110100
[macOS] Bring up "complex_layout" devicelab, startup tests for x64 #110100
Conversation
06f878f
to
9e8c678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9e8c678
to
cea1d32
Compare
ddaa1c9
to
a55054f
Compare
dev/benchmarks/complex_layout/windows/flutter/generated_plugin_registrant.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the title to just x64 for now since arm64 testing will depend on either (a) eliminating our reliance on x64 binaries under rosetta in our engine/tooling build products like gen_snapshot
and libimobiledevice (b) getting rosetta on our machine images.
Of those, we're getting pushback on (b) and (a) is the better choice regardless.
a55054f
to
d1cd200
Compare
edddc76
to
4517d34
Compare
Reason
Related
fixes #110083
Pre-launch Checklist
///
).