Fill in SliverConstraints fields missing from ==, hashCode, toString #143661

gnprice · 2024-02-18T05:49:02Z

I was doing some debugging on a RenderSliver subclass, and found
that SliverConstraints.toString was missing the precedingScrollExtent
field.

Add that, and add both that field and userScrollDirection to the
== and hashCode implementations, which had been skipping them,
so that all three methods now handle all the class's fields.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I was doing some debugging on a RenderSliver subclass, and found that SliverConstraints.toString was missing the precedingScrollExtent field. Add that, and add both that field and userScrollDirection to the `==` and hashCode implementations, which had been skipping them, so that all three methods now handle all the class's fields.

packages/flutter/lib/src/rendering/sliver.dart

goderbauer

LGTM

…oString (flutter/flutter#143661)

flutter/flutter@3b5a2ec...8f84f3f 2024-03-06 [email protected] Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693) 2024-03-06 [email protected] Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668) 2024-03-06 [email protected] Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661) 2024-03-06 [email protected] Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659) 2024-03-06 [email protected] Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661) 2024-03-06 [email protected] Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653) 2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174) 2024-03-05 [email protected] Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248) 2024-03-05 [email protected] Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161) 2024-03-05 [email protected] Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639) 2024-03-05 [email protected] Updated the smiley TextButton example again (flutter/flutter#144630) 2024-03-05 [email protected] Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392) 2024-03-05 [email protected] Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629) 2024-03-05 [email protected] Add regression test for TabBar crash (flutter/flutter#144627) 2024-03-05 [email protected] Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628) 2024-03-05 [email protected] remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576) 2024-03-05 [email protected] Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624) 2024-03-05 [email protected] Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…oString (flutter/flutter#143661)

flutter/flutter@3b5a2ec...8f84f3f 2024-03-06 [email protected] Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693) 2024-03-06 [email protected] Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668) 2024-03-06 [email protected] Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661) 2024-03-06 [email protected] Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659) 2024-03-06 [email protected] Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661) 2024-03-06 [email protected] Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653) 2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174) 2024-03-05 [email protected] Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248) 2024-03-05 [email protected] Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161) 2024-03-05 [email protected] Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639) 2024-03-05 [email protected] Updated the smiley TextButton example again (flutter/flutter#144630) 2024-03-05 [email protected] Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392) 2024-03-05 [email protected] Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629) 2024-03-05 [email protected] Add regression test for TabBar crash (flutter/flutter#144627) 2024-03-05 [email protected] Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628) 2024-03-05 [email protected] remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576) 2024-03-05 [email protected] Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624) 2024-03-05 [email protected] Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 18, 2024

gnprice requested a review from matthew-carroll February 20, 2024 17:22

matthew-carroll removed their request for review February 20, 2024 19:46

goderbauer reviewed Feb 20, 2024

View reviewed changes

packages/flutter/lib/src/rendering/sliver.dart Show resolved Hide resolved

goderbauer approved these changes Mar 5, 2024

View reviewed changes

gnprice added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024

auto-submit bot merged commit 6b9d3ea into flutter:master Mar 6, 2024
66 checks passed

gnprice deleted the pr-sliverconstraints branch March 6, 2024 03:24

engine-flutter-autoroll mentioned this pull request Mar 6, 2024

Roll Flutter from 3b5a2ecf992d to d0c8ad28cf03 (17 revisions) flutter/packages#6275

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2024

6b9d3ea Fill in SliverConstraints fields missing from ==, hashCode, t…

e94b9b4

…oString (flutter/flutter#143661)

engine-flutter-autoroll mentioned this pull request Mar 6, 2024

Roll Flutter from 3b5a2ecf992d to 8f84f3f32ddc (18 revisions) flutter/packages#6276

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2024

6b9d3ea Fill in SliverConstraints fields missing from ==, hashCode, t…

d523080

…oString (flutter/flutter#143661)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

6b9d3ea Fill in SliverConstraints fields missing from ==, hashCode, t…

f373f15

…oString (flutter/flutter#143661)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fill in SliverConstraints fields missing from ==, hashCode, toString #143661

Fill in SliverConstraints fields missing from ==, hashCode, toString #143661

gnprice commented Feb 18, 2024 •

edited

Loading

goderbauer left a comment

Fill in SliverConstraints fields missing from ==, hashCode, toString #143661

Fill in SliverConstraints fields missing from ==, hashCode, toString #143661

Conversation

gnprice commented Feb 18, 2024 • edited Loading

Pre-launch Checklist

goderbauer left a comment

Choose a reason for hiding this comment

gnprice commented Feb 18, 2024 •

edited

Loading