Enable asset transformation for `flutter build` for iOS, Android, Windows, MacOS, Linux, and web (also `flutter run` without hot reload support) #143815

andrewkolos · 2024-02-21T04:13:29Z

See title. These are are the platforms that use the CopyAssets Target as part of their build target.

Partial implementation of #143348.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter_tools/lib/src/build_system/tools/asset_transformer.dart

…lized field

packages/flutter_tools/lib/src/build_system/tools/asset_transformer.dart

packages/flutter_tools/test/general.shard/build_system/targets/asset_transformer_test.dart

packages/flutter_tools/lib/src/build_system/targets/assets.dart

andrewkolos · 2024-02-22T03:57:31Z

I suspect caching is likely to not work properly when path-dependencies are used as transformers.

Consider the scenario where I have a path dependency in use that as a transformer. I perform a build, edit the transformer's code, and then run a build again. The CopyAssets target doesn't depend on code files from path dependencies, so the asset won't get retransformed.

edit: I'm content in adding this as a TODO on the tracking issue.

christopherfujino · 2024-02-22T21:06:18Z

I suspect caching is likely to not work properly when path-dependencies are used as transformers.

Consider the scenario where I have a path dependency in use that as a transformer. I perform a build, edit the transformer's code, and then run a build again. The CopyAssets target doesn't depend on code files from path dependencies, so the asset won't get retransformed.

edit: I'm content in adding this as a TODO on the tracking issue.

Unless you think there's some reason that path dependencies would be used MORE in this particular workflow, I'm ok with leaving this as a TODO. I think path deps in pubspec.yaml invalidates all kinds of caching assumptions in general.

andrewkolos · 2024-02-22T21:08:39Z

Unless you think there's some reason that path dependencies would be used MORE in this particular workflow, I'm ok with leaving this as a TODO. I think path deps in pubspec.yaml invalidates all kinds of caching assumptions in general.

Indeed, see #141626 as an example.

christopherfujino

Overall this LGTM. I weakly feel we should have some integration testing for this, but I'll comment my thoughts on #143348, I don't think it should block landing this, especially as the tests we do have seem to cover interesting API surface well.

andrewkolos · 2024-02-22T21:24:49Z

Overall this LGTM. I weakly feel we should have some integration testing for this, but I'll comment my thoughts on #143348, I don't think it should block landing this, especially as the tests we do have seem to cover interesting API surface well.

Ack. I added a note about path dependencies to the tracking issue OP. Thanks for the quite fantastic review here—you caught at least one would-be P1.

auto-submit · 2024-02-22T22:18:48Z

auto label is removed for flutter/flutter/143815, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

christopherfujino · 2024-02-22T22:33:41Z

Ack. I added a note about path dependencies to the tracking issue OP. Thanks for the quite fantastic review here—you caught at least one would-be P1.

Was that not failing the build if the transformer failed? or something else?

andrewkolos · 2024-02-22T22:37:17Z

Ack. I added a note about path dependencies to the tracking issue OP. Thanks for the quite fantastic review here—you caught at least one would-be P1.

Was that not failing the build if the transformer failed? or something else?

Yeah, that's what came to mind.

edit: FYI I see Google testing failing, and I have a g3fix going out

…in future

…oid, Windows, MacOS, Linux, and web (also `flutter run` without hot reload support) (flutter/flutter#143815)

flutter/flutter@39585e6...f6c1082 2024-02-24 [email protected] Roll Flutter Engine from 81035b7d56ef to 1d7d5e613d7e (1 revision) (flutter/flutter#144085) 2024-02-24 [email protected] Roll Flutter Engine from a148bdb63740 to 81035b7d56ef (2 revisions) (flutter/flutter#144083) 2024-02-24 [email protected] Roll Flutter Engine from 3c036c081534 to a148bdb63740 (1 revision) (flutter/flutter#144077) 2024-02-24 [email protected] Roll Flutter Engine from 738042295f97 to 3c036c081534 (2 revisions) (flutter/flutter#144073) 2024-02-24 [email protected] Roll Flutter Engine from ca2452074a49 to 738042295f97 (4 revisions) (flutter/flutter#144071) 2024-02-24 [email protected] Roll Flutter Engine from 9409b75e8f35 to ca2452074a49 (2 revisions) (flutter/flutter#144068) 2024-02-24 [email protected] Adding support for DDC modules when running Flutter Web in debug mode (flutter/flutter#141423) 2024-02-24 [email protected] Roll Flutter Engine from 733163c4e5d7 to 9409b75e8f35 (1 revision) (flutter/flutter#144061) 2024-02-23 [email protected] allow optional direct injection of Config instance into DevFS (flutter/flutter#144002) 2024-02-23 [email protected] Enable asset transformation for `flutter build` for iOS, Android, Windows, MacOS, Linux, and web (also `flutter run` without hot reload support) (flutter/flutter#143815) 2024-02-23 [email protected] Roll Flutter Engine from 5d1c0d4dc327 to 733163c4e5d7 (1 revision) (flutter/flutter#144058) 2024-02-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.4 to 3.24.5 (flutter/flutter#144059) 2024-02-23 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.1 to 4.0.2 (flutter/flutter#144060) 2024-02-23 [email protected] Render the warm up frame in a proper rendering process (flutter/flutter#143290) 2024-02-23 [email protected] Roll Flutter Engine from fbc9b889aee9 to 5d1c0d4dc327 (2 revisions) (flutter/flutter#144049) 2024-02-23 [email protected] Roll Flutter Engine from b5bebfe43d29 to fbc9b889aee9 (3 revisions) (flutter/flutter#144041) 2024-02-23 [email protected] disable debug banner in m3 page test apps. (flutter/flutter#143857) 2024-02-23 [email protected] Relands "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (reverted in #143801) (flutter/flutter#143954) 2024-02-23 [email protected] Roll Flutter Engine from 5f99a6c3289e to b5bebfe43d29 (1 revision) (flutter/flutter#144035) 2024-02-23 [email protected] Implementing null-aware operators throughout the repository (flutter/flutter#143804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…oid, Windows, MacOS, Linux, and web (also `flutter run` without hot reload support) (flutter/flutter#143815)

flutter/flutter@39585e6...f6c1082 2024-02-24 [email protected] Roll Flutter Engine from 81035b7d56ef to 1d7d5e613d7e (1 revision) (flutter/flutter#144085) 2024-02-24 [email protected] Roll Flutter Engine from a148bdb63740 to 81035b7d56ef (2 revisions) (flutter/flutter#144083) 2024-02-24 [email protected] Roll Flutter Engine from 3c036c081534 to a148bdb63740 (1 revision) (flutter/flutter#144077) 2024-02-24 [email protected] Roll Flutter Engine from 738042295f97 to 3c036c081534 (2 revisions) (flutter/flutter#144073) 2024-02-24 [email protected] Roll Flutter Engine from ca2452074a49 to 738042295f97 (4 revisions) (flutter/flutter#144071) 2024-02-24 [email protected] Roll Flutter Engine from 9409b75e8f35 to ca2452074a49 (2 revisions) (flutter/flutter#144068) 2024-02-24 [email protected] Adding support for DDC modules when running Flutter Web in debug mode (flutter/flutter#141423) 2024-02-24 [email protected] Roll Flutter Engine from 733163c4e5d7 to 9409b75e8f35 (1 revision) (flutter/flutter#144061) 2024-02-23 [email protected] allow optional direct injection of Config instance into DevFS (flutter/flutter#144002) 2024-02-23 [email protected] Enable asset transformation for `flutter build` for iOS, Android, Windows, MacOS, Linux, and web (also `flutter run` without hot reload support) (flutter/flutter#143815) 2024-02-23 [email protected] Roll Flutter Engine from 5d1c0d4dc327 to 733163c4e5d7 (1 revision) (flutter/flutter#144058) 2024-02-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.4 to 3.24.5 (flutter/flutter#144059) 2024-02-23 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.1 to 4.0.2 (flutter/flutter#144060) 2024-02-23 [email protected] Render the warm up frame in a proper rendering process (flutter/flutter#143290) 2024-02-23 [email protected] Roll Flutter Engine from fbc9b889aee9 to 5d1c0d4dc327 (2 revisions) (flutter/flutter#144049) 2024-02-23 [email protected] Roll Flutter Engine from b5bebfe43d29 to fbc9b889aee9 (3 revisions) (flutter/flutter#144041) 2024-02-23 [email protected] disable debug banner in m3 page test apps. (flutter/flutter#143857) 2024-02-23 [email protected] Relands "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (reverted in #143801) (flutter/flutter#143954) 2024-02-23 [email protected] Roll Flutter Engine from 5f99a6c3289e to b5bebfe43d29 (1 revision) (flutter/flutter#144035) 2024-02-23 [email protected] Implementing null-aware operators throughout the repository (flutter/flutter#143804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

init

7d9bcc2

andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 21, 2024

andrewkolos mentioned this pull request Feb 21, 2024

☂️ Implement pluggable transformation (via packages) of assets at build time #143348

Closed

13 tasks

andrewkolos changed the title ~~Enable asset transformation for flutter build for iOS, Android, Windows, MacOS, Linux~~ Enable asset transformation for flutter build for iOS, Android, Windows, MacOS, Linux, and web Feb 21, 2024

lint

27b6838

andrewkolos requested a review from christopherfujino February 21, 2024 05:15

andrewkolos marked this pull request as ready for review February 21, 2024 05:15