Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll pub packages #151539

Conversation

flutter-pub-roller-bot
Copy link
Contributor

This PR was generated by flutter update-packages --force-upgrade.

@flutter-pub-roller-bot flutter-pub-roller-bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 10, 2024
@flutter-pub-roller-bot flutter-pub-roller-bot added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2024
Copy link
Contributor

auto-submit bot commented Jul 10, 2024

auto label is removed for flutter/flutter/151539, due to - The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac channels_integration_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 hot_mode_dev_cycle_macos_target__benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_impeller has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_skwasm_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_0 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_long_running_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_benchmarks_html has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux realm_checker has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux android_preview_tool_integration_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux run_release_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux run_debug_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux plugin_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_plugin_fat_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_java8_compile_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_desugar_classes_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_slow has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux engine_dependency_proxy_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_3_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu android views has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux skp_generator has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer
Copy link
Member

@dcharkes I believe your PR (#151534) addresses these failures? Once that lands, can you close this PR to get the bot going again?

@dcharkes
Copy link
Contributor

@dcharkes I believe your PR (#151534) addresses these failures? Once that lands, can you close this PR to get the bot going again?

I thought the packages from dart-lang/native were excluded from automatic upgrading? (We're actively working on them and regularly doing breaking changes.)

@goderbauer
Copy link
Member

As far as I can tell from https://github.com/flutter/flutter/blob/32c0c39ea5d81f0c9b3e51a513c76c4ca3d5d111/packages/flutter_tools/lib/src/update_packages_pins.dart they are currently not excluded. Should they be pinned to always require manual intervention to roll them? cc @christopherfujino who may have more context.

@christopherfujino
Copy link
Member

As far as I can tell from https://github.com/flutter/flutter/blob/32c0c39ea5d81f0c9b3e51a513c76c4ca3d5d111/packages/flutter_tools/lib/src/update_packages_pins.dart they are currently not excluded. Should they be pinned to always require manual intervention to roll them? cc @christopherfujino who may have more context.

I don't have more context, I would echo what Michael said, if we want to ensure the autoroller is not rolling these, we should pin them in the library he linked.

@dcharkes dcharkes closed this Jul 12, 2024
auto-submit bot pushed a commit that referenced this pull request Jul 12, 2024
Stop trying to roll the dependencies for native assets automatically.

They are under active development (pre 1.0.0), and have frequent breaking changes. I'll be rolling these manually.
(We have the same setup in the Dart SDK, not auto-rolling dart-lang/native via DEPS.)

Related comment:

* #151539 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants