Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-format Framework #160545

Merged
merged 20 commits into from
Dec 19, 2024
Merged

Auto-format Framework #160545

merged 20 commits into from
Dec 19, 2024

Conversation

goderbauer
Copy link
Member

This auto-formats all *.dart files in the repository outside of the engine subdirectory and enforces that these files stay formatted with a presubmit check.

Reviewers: Please carefully review all the commits except for the one titled "formatted". The "formatted" commit was auto-generated by running dev/tools/format.sh -a -f. The other commits were hand-crafted to prepare the repo for the formatting change. I recommend reviewing the commits one-by-one via the "Commits" tab and avoiding Github's "Files changed" tab as it will likely slow down your browser because of the size of this PR.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. f: gestures flutter/packages/flutter/gestures repository. f: focus Focus traversal, gaining or losing focus labels Dec 18, 2024
@goderbauer goderbauer mentioned this pull request Dec 18, 2024
Closed
Piinks
Piinks approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let there be formatting in flutter/flutter, and let it begin with me!
LGTM

@goderbauer
Copy link
Member Author

About "google testing": Looks like frob is broken in some way and we decided to sort this out with the next roll into google3.

@goderbauer goderbauer added this pull request to the merge queue Dec 19, 2024
Merged via the queue into flutter:master with commit 5491c8c Dec 19, 2024
174 of 175 checks passed
@goderbauer goderbauer deleted the finalFormat3 branch December 19, 2024 21:04
@jmagman jmagman mentioned this pull request Dec 30, 2024
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
9056f3b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
4e3a058
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
ad3f98a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
3a36be3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
3dd3bbe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
786c3f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
ce2fee4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
2ac6021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
08c9d1e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
18830e7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
3ba4acb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
36e261b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
6382cb3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
9b2888b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5491c8c14 Auto-format Framework (flutter/flutter#160545)
d2877d8
@Piinks Piinks mentioned this pull request Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goderbauer @gspencergoog @Piinks @LongCatIsLooong