-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ColorScheme.dark() colors to match the Material Dark theme specification #36106
Updated ColorScheme.dark() colors to match the Material Dark theme specification #36106
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygine page and make sure this patch meets those guidelines before LGTMing. /cc @dnfield |
colors to match the spec.
54fd73a
to
f2825e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a pair of (trivial) tests that verify the default light and dark color scheme colors per the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ecification (flutter#36106) Updated ColorScheme.dark() primaryVariant, surface, background and error colors to match the spec.
Description
According the the Material Dark theme spec the default dark color scheme's
primaryVariant
,surface
,background
anderror
colors should be:Which are different than the current implementation of
ColorScheme.dark()
. As this is supposed to be the default dark theme for applications to use, it should use the recommended colors.This PR updates
ColorScheme.dark()
to the match the spec colors.Related Issues
Fixes: #36021
Tests
Added a new
color_scheme_test.dart
that checks the light and dark scheme against the spec values.Checklist
///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
If you depended on
ColorScheme.dark()
to provide the current implementation's colors, then you can just usecopyWith
to set those colors back to the original non-spec colors using the following:See the announcement email for more details.