Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tool] Allow analytics without a terminal attached #36208

Merged
merged 1 commit into from
Jul 16, 2019
Merged

[flutter_tool] Allow analytics without a terminal attached #36208

merged 1 commit into from
Jul 16, 2019

Conversation

zanderso
Copy link
Member

Description

The Flutter tool may be wrapped in a shell script, for example, in which case we'd still like to collect analytics.

Tests

The relevant test was updated.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 15, 2019
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #36208 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36208      +/-   ##
==========================================
- Coverage   55.03%   55.01%   -0.02%     
==========================================
  Files         187      187              
  Lines       17241    17242       +1     
==========================================
- Hits         9488     9486       -2     
- Misses       7753     7756       +3
Flag Coverage Δ
#flutter_tool 55.01% <66.66%> (-0.02%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/usage.dart 75.55% <ø> (ø) ⬆️
.../flutter_tools/lib/src/runner/flutter_command.dart 82.66% <100%> (+0.07%) ⬆️
packages/flutter_tools/lib/src/base/utils.dart 94.47% <50%> (-0.51%) ⬇️
...lutter_tools/lib/src/build_system/targets/ios.dart 0% <0%> (-100%) ⬇️
...tter_tools/lib/src/build_system/targets/macos.dart 64.7% <0%> (-11.77%) ⬇️
...utter_tools/lib/src/build_system/targets/dart.dart 83.33% <0%> (-1.29%) ⬇️
packages/flutter_tools/lib/src/version.dart 96.05% <0%> (-0.99%) ⬇️
packages/flutter_tools/lib/src/build_info.dart 69.06% <0%> (-0.56%) ⬇️
.../flutter_tools/lib/src/fuchsia/fuchsia_device.dart 55.76% <0%> (+0.37%) ⬆️
packages/flutter_tools/lib/src/vmservice.dart 39.61% <0%> (+0.47%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ce64a...9d18ef3. Read the comment docs.

@zanderso zanderso merged commit fa65ddf into flutter:master Jul 16, 2019
@zanderso zanderso deleted the rm-terminal-check branch July 16, 2019 16:48
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants