Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tool] More gracefully handle Android sdkmanager failure #37194

Merged
merged 1 commit into from
Jul 30, 2019
Merged

[flutter_tool] More gracefully handle Android sdkmanager failure #37194

merged 1 commit into from
Jul 30, 2019

Conversation

zanderso
Copy link
Member

Description

This PR detects a failure to run the Android sdkmanager tool, and throws a ToolExit with appropriate advice.

Related Issues

#36152

Tests

I added the following tests:

Tests added in android_workflow_test.dart

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 29, 2019
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #37194 into master will increase coverage by 0.7%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #37194     +/-   ##
=========================================
+ Coverage   54.55%   55.26%   +0.7%     
=========================================
  Files         193      193             
  Lines       17849    17855      +6     
=========================================
+ Hits         9738     9867    +129     
+ Misses       8111     7988    -123
Flag Coverage Δ
#flutter_tool 55.26% <86.66%> (+0.7%) ⬆️
Impacted Files Coverage Δ
...ages/flutter_tools/lib/src/base/user_messages.dart 49.52% <0%> (-0.48%) ⬇️
...lutter_tools/lib/src/android/android_workflow.dart 63.52% <89.65%> (-0.77%) ⬇️
packages/flutter_tools/lib/src/device.dart 47.59% <0%> (-9.64%) ⬇️
packages/flutter_tools/lib/src/cache.dart 41.83% <0%> (-0.77%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.73% <0%> (+0.48%) ⬆️
packages/flutter_tools/lib/src/base/process.dart 80.46% <0%> (+0.78%) ⬆️
packages/flutter_tools/lib/src/build_info.dart 70.71% <0%> (+1.65%) ⬆️
packages/flutter_tools/lib/src/ios/mac.dart 27.83% <0%> (+4.81%) ⬆️
...ges/flutter_tools/lib/src/android/android_sdk.dart 77.9% <0%> (+30.71%) ⬆️
...ckages/flutter_tools/lib/src/commands/channel.dart 72.3% <0%> (+69.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8be195...0c5bc9a. Read the comment docs.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit a5d23d2 into flutter:master Jul 30, 2019
@zanderso zanderso deleted the catch-android-license-fail branch July 30, 2019 15:20
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants