resizeToAvoidBottomInset Cupertino without NavBar #37319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
added
framework
|
@xster Just checking, but ignoring |
|
That totally looks like a bug. Thanks for fixing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CupertinoPageScaffold was ignoring
resizeToAvoidBottomInsetwhen there was nonavigationBar. This PR makes it respect the parameter in either case.The before and after with
resizeToAvoidBottomInset: truelooks like this:Related Issues
Closes #34946
Tests
Added a test to verify that a CupertinoTextField moves up when
resizeToAvoidBottomInsetis true, even without a navbar.