Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide text selection handle after entering text #37436

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

justinmc
Copy link
Contributor

@justinmc justinmc commented Aug 1, 2019

Description

On native android, when the caret/handle is showing in a text field, entering any text hides it. This makes Flutter do the same.

After:
type_hide_handle

Tests

I added a test that checks that the handle is hidden after entering additional text.

@justinmc justinmc requested a review from johnsonmh August 1, 2019 23:02
@justinmc justinmc self-assigned this Aug 1, 2019
@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 1, 2019
Copy link
Contributor

@johnsonmh johnsonmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc justinmc merged commit 954714c into flutter:master Aug 2, 2019
@justinmc justinmc deleted the handle-shows-during-entry branch August 2, 2019 17:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants