Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows path for dwds/web builds #37658

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

jonahwilliams
Copy link
Member

Description

This should be the platform separator.

@jonahwilliams jonahwilliams added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 6, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a785db7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37658   +/-   ##
=========================================
  Coverage          ?   55.25%           
=========================================
  Files             ?      193           
  Lines             ?    18144           
  Branches          ?        0           
=========================================
  Hits              ?    10025           
  Misses            ?     8119           
  Partials          ?        0
Flag Coverage Δ
#flutter_tool 55.25% <100%> (?)
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/web/web_fs.dart 24.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a785db7...13a1678. Read the comment docs.

@jonahwilliams jonahwilliams requested a review from yjbanov August 6, 2019 05:14
@jonahwilliams jonahwilliams merged commit 91b8dcb into flutter:master Aug 6, 2019
@jonahwilliams jonahwilliams deleted the fix_windows_path_dwds branch August 6, 2019 17:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants