Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gem documentation generation on Cirrus #37740

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 7, 2019

Description

Pass in -N when gem installing on Cirrus to disable document generation. This flag is already used in the Dockerfile for coveralls, bundler, etc.

Shaves off ~2.5 seconds on my machine. Not the most impressive, but there's no need for gem documents on CI so save the time, networking, and disk space.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 7, 2019
@jmagman jmagman self-assigned this Aug 7, 2019
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 67e5b9c into flutter:master Aug 8, 2019
@jmagman jmagman deleted the gem-no-docs branch August 8, 2019 19:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants