-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ephemeral directories during flutter clean #37966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #37966 +/- ##
=========================================
+ Coverage 54.74% 56.05% +1.3%
=========================================
Files 194 194
Lines 18170 18169 -1
=========================================
+ Hits 9948 10185 +237
+ Misses 8222 7984 -238
Continue to review full report at Codecov.
|
void _deleteFile(FileSystemEntity file) { | ||
final String path = file.path; | ||
printStatus("Deleting '$path${fs.path.separator}'."); | ||
if (file.existsSync()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: flip the sense of the if and un-indent, like:
if (!file.existsSync()) {
return;
}
try {
...
}
...
you might also move the printStatus()
after checking that the object exists.
Description
Remove ephemeral directories used by modules during
flutter clean
Related Issues
Fixes #37909.
Tests
Updated "removes build and .dart_tool and ephemeral directories"
Checklist
///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change