Fix getOffsetToReveal for growthDirection reversed and AxisDirection down or right #38441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the same differentiation for computing offset based on growthDirection to the AxisDirection.down and .right cases that existed for .up and .left cases.
Related Issues
#38301
Tests
I added the following tests:
Viewport getOffsetToReveal Sliver - up - reverse growth
Viewport getOffsetToReveal Sliver - left - reverse growth
both based on
Viewport getOffsetToReveal Sliver - up
Viewport getOffsetToReveal Sliver - left
respectively, but with reverse growth slivers.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?