Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getOffsetToReveal for growthDirection reversed and AxisDirection down or right #38441

Merged
merged 8 commits into from
Aug 16, 2019

Conversation

tarobins
Copy link
Contributor

@tarobins tarobins commented Aug 13, 2019

Description

Added the same differentiation for computing offset based on growthDirection to the AxisDirection.down and .right cases that existed for .up and .left cases.

Related Issues

#38301

Tests

I added the following tests:

Viewport getOffsetToReveal Sliver - up - reverse growth
Viewport getOffsetToReveal Sliver - left - reverse growth

both based on

Viewport getOffsetToReveal Sliver - up
Viewport getOffsetToReveal Sliver - left

respectively, but with reverse growth slivers.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x ] I signed the CLA.
  • [x ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • [ x] I updated/added relevant documentation (doc comments with ///).
  • [x ] All existing and new tests are passing.
  • [x ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • [ x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • [ x ] No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 13, 2019
@tarobins tarobins marked this pull request as ready for review August 14, 2019 17:17
@tarobins tarobins requested a review from goderbauer August 14, 2019 17:17
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarobins tarobins merged commit 1d03459 into flutter:master Aug 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants