Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding header rule to FB hosting for API docs. #39345

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Conversation

RedBrogdon
Copy link
Contributor

Description

This is a modification of the Firebase Hosting config used for https://api.flutter.dev. It adds a CORS Access-Control-Allow-Origin header to the snippets directory naming https://dartpad.dev as an allowed origin. This will allow DartPad to load samples directly from the API Doc server into the browser using client-side Dart.

FWIW, this is the first change to the config since @sethladd set it up three years ago.

See also: https://firebase.google.com/docs/hosting/full-config

Related Issues

None that I know of.

Tests

I have not added any tests, since this is a configuration change for hosting rather than an actual code change.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 27, 2019
@RedBrogdon RedBrogdon merged commit aff1634 into master Aug 28, 2019
@RedBrogdon RedBrogdon deleted the cors_for_docs branch August 28, 2019 17:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants