Adding header rule to FB hosting for API docs. #39345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a modification of the Firebase Hosting config used for https://api.flutter.dev. It adds a CORS
Access-Control-Allow-Origin
header to thesnippets
directory naming https://dartpad.dev as an allowed origin. This will allow DartPad to load samples directly from the API Doc server into the browser using client-side Dart.FWIW, this is the first change to the config since @sethladd set it up three years ago.
See also: https://firebase.google.com/docs/hosting/full-config
Related Issues
None that I know of.
Tests
I have not added any tests, since this is a configuration change for hosting rather than an actual code change.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?