Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to .ci.yaml #82960

Merged
merged 3 commits into from
May 20, 2021
Merged

Migrate to .ci.yaml #82960

merged 3 commits into from
May 20, 2021

Conversation

CaseyHillers
Copy link
Contributor

Issues

#82303

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label May 19, 2021
@google-cla google-cla bot added the cla: yes label May 19, 2021
@CaseyHillers CaseyHillers changed the title Migrate framework to .ci.yaml Migrate to .ci.yaml May 19, 2021
@CaseyHillers CaseyHillers mentioned this pull request May 19, 2021
Closed
9 tasks
@christopherfujino
Copy link
Member

analysis failling:

/tmp/flutter sdk/.ci.yaml:1503: trailing blank line
/tmp/flutter sdk/dev/README.md:8: trailing blank line

christopherfujino
christopherfujino approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers merged commit 9ecee62 into flutter:master May 20, 2021
@CaseyHillers CaseyHillers deleted the star-migration branch May 20, 2021 03:09
@Hixie
Copy link
Contributor

Hixie commented Jun 4, 2021

@CaseyHillers Can you update https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard accordingly?

@CaseyHillers
Copy link
Contributor Author

Good catch @Hixie, I updated the documentation with the .ci.yaml workflow

@Hixie
Copy link
Contributor

Hixie commented Jun 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyHillers @christopherfujino @Hixie