Remove some unneeded ClipRect widgets #8558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change goes beyond just removing unneeded clip rects. The drawer demo had been set up to resemble the drawers in Google apps like GMail, Drive, Photos, etc. Although the new version is simpler, it doesn't demo how to code the dual-view drawer that appears in our products. |
|
The Stack dartdoc still doesn't mention clipping explicitly. |
The diff might look confusing, but all I did was remove the clip. |
|
Actually, now that I look at it more, I don't think we can remove that clip. |
|
Sorry about that, I have bad diff reading habits. LGTM |
Stack clips internally if it has visual overflow and Image never draws outside its bounds.
|
Ok, now I think this patch is just wrong. I'm going to abandon it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack clips internally if it has visual overflow and Image never draws outside
its bounds.