Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Add a script that checks that all source files have a valid license block. #63

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

chinmaygarde
Copy link
Member

@chinmaygarde chinmaygarde commented Mar 8, 2022

Also fixes the files with missing licenses. This check is somewhat easy with
Impeller than in the engine because all source files must have the same license
block.

Resolves an action item in the umbrella issue flutter/flutter#97686

The script may eventually be run as part of a CI step.

…lock.

Also fixes the files with missing licenses. This check is somewhat easy with
Impeller than in the engine because all source files must have the same license
block.

Resolves an action item in the umbrella issue flutter/flutter#97686
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ nit.

return True

return False

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Two newlines between top-levels here and below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chinmaygarde chinmaygarde merged commit acfaa20 into flutter:main Mar 8, 2022
@chinmaygarde chinmaygarde deleted the check_licenses branch March 8, 2022 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants