Document how to suggest lints for flutter_lints #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mit-mit
reviewed
Apr 19, 2022
| @@ -58,7 +58,21 @@ linter: | |||
| # https://dart.dev/guides/language/analysis-options | |||
| ``` | |||
|
|
|||
| ## Adding new lints | |||
|
|
|||
| Please file a [lint proposal] issue to suggest that an existing lint rule should | |||
There was a problem hiding this comment.
I think you need [lint proposal][] for that link to work?
There was a problem hiding this comment.
The style without the [] also works: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links
I also verified that the links further up in the readme using the same style link correctly, see https://pub.dev/packages/flutter_lints/versions/2.0.0.
pq
approved these changes
Apr 19, 2022
packages/flutter_lints/README.md
Outdated
| ## Adding new lints | ||
|
|
||
| Please file a [lint proposal] issue to suggest that an existing lint rule should | ||
| be added to this packages. The benefits and risks of adding a lint should be |
packages/flutter_lints/README.md
Outdated
| [Flutter]: https://flutter.dev | ||
| [dart analyzer]: https://dart.dev/guides/language/analysis-options | ||
| [Dart-enabled IDEs]: https://dart.dev/tools#ides-and-editors | ||
| [package:lints]: https://pub.dev/packages/lints | ||
| [lint proposal]: https://github.com/dart-lang/lints/issues/new/choose |
There was a problem hiding this comment.
Consider going a step past the chooser?
https://github.com/dart-lang/lints/issues/new?&labels=type-lint&template=lint-propoposal.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.