Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router] Remove unused navigator keys #3708

Merged
merged 3 commits into from
Apr 28, 2023
Merged

[go_router] Remove unused navigator keys #3708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b2165
Remove unused navigator keys
GP4cK Apr 14, 2023
5746f83
Update version and changelog
GP4cK Apr 14, 2023
31b95ed
Merge branch 'main' into remove-unused-navigator-key
GP4cK Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/go_router/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.5.9

- Removes navigator keys from `GoRouteData` and `ShellRouteData`.

## 6.5.8

- Adds name parameter to `TypedGoRoute`
Expand All @@ -16,7 +20,7 @@

## 6.5.4

- Remove navigator keys from `TypedGoRoute` and `TypedShellRoute`.
- Removes navigator keys from `TypedGoRoute` and `TypedShellRoute`.

## 6.5.3

Expand Down
8 changes: 0 additions & 8 deletions packages/go_router/lib/src/route_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,6 @@ abstract class GoRouteData extends RouteData {
static final Expando<GoRouteData> _stateObjectExpando = Expando<GoRouteData>(
'GoRouteState to GoRouteData expando',
);

/// [navigatorKey] is used to point to a certain navigator
///
/// It will use the given key to find the right navigator for [GoRoute]
GlobalKey<NavigatorState>? get navigatorKey => null;
}

/// Base class for supporting
Expand Down Expand Up @@ -208,9 +203,6 @@ abstract class ShellRouteData extends RouteData {
Expando<ShellRouteData>(
'GoRouteState to ShellRouteData expando',
);

/// It will be used to instantiate [Navigator] with the given key
GlobalKey<NavigatorState>? get navigatorKey => null;
}

/// A superclass for each typed route descendant
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: go_router
description: A declarative router for Flutter based on Navigation 2 supporting
deep linking, data-driven routes and more
version: 6.5.8
version: 6.5.9
repository: https://github.com/flutter/packages/tree/main/packages/go_router
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22

Expand Down