Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tool] [Code Excerpt] allow excerpts in example readme #3758

Merged
merged 5 commits into from
Apr 19, 2023
Merged

[Tool] [Code Excerpt] allow excerpts in example readme #3758

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1fa6d9
Allow example readme snippets
tarrinneal Apr 18, 2023
a4de0d4
changelog
tarrinneal Apr 18, 2023
791aad8
test
tarrinneal Apr 19, 2023
56a2f85
clearer
tarrinneal Apr 19, 2023
96d10b2
final test
tarrinneal Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions script/tool/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.13.4+4

* Allows code excerpts in `example/README.md`.

## 0.13.4+3

* Moves source to flutter/packages.
Expand Down
3 changes: 3 additions & 0 deletions script/tool/lib/src/update_excerpts_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ class UpdateExcerptsCommand extends PackageLoopingCommand {
if (!await _injectSnippets(example, targetPackage: package)) {
return PackageResult.fail(<String>['Unable to inject excerpts']);
}
if (!await _injectSnippets(example, targetPackage: example)) {
return PackageResult.fail(<String>['Unable to inject excerpts']);
}
} finally {
// Clean up the pubspec changes and extracted excerpts directory.
_undoPubspecChanges(example);
Expand Down
2 changes: 1 addition & 1 deletion script/tool/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: flutter_plugin_tools
description: Productivity and CI utils for flutter/packages
repository: https://github.com/flutter/packages/tree/main/script/tool
version: 0.13.4+3
version: 0.13.4+4

dependencies:
args: ^2.1.0
Expand Down