Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tool] Use new pub cache location for publish #3962

Merged
merged 2 commits into from
May 11, 2023
Merged

[tool] Use new pub cache location for publish #3962

merged 2 commits into from
May 11, 2023

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented May 11, 2023 •
edited
Loading

As of Dart 3.0 (Flutter 3.10), the location that the tool was using for the pub cache wasn't being read, breaking autopublish in CI. This updates to the new location, and adds tests for it.

Should fix the fact that the release step hangs on every package change now.

@stuartmorgan
[tool] Use new pub cache location for publish
702523c 
As of Dart 3.0 (Flutter 3.10), the location that the tool was using for
the pub cache wasn't being read, breaking autopublish in CI.
tarrinneal
tarrinneal approved these changes May 11, 2023
View reviewed changes
script/tool/lib/src/publish_command.dart
throw ToolExit(1);
}

return p.join(cacheDir, 'credentials.json');
}();
return path.join(configDir, 'pub-credentials.json');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You've changed p -> path in multiple places, but the import is still as p.

Copy link
Contributor Author

@stuartmorgan stuartmorgan May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually correct; path is a p.Context instance (from our base command class) constructed based on the platform instance, which means it follows the mock platform if one is injected by tests.

What makes this extra confusing I think is that the path package provides everything as both methods on a context, and free functions (which call the method of the same name on the default context). So calling the free functions with a prefixed import and calling the methods on an instance look the same, even though they are actually calling different things.

@stuartmorgan
Copy link
Contributor Author

Landing on red to (hopefully) avoid continued tree breakage.

@stuartmorgan stuartmorgan merged commit 5b7d732 into flutter:main May 11, 2023
@stuartmorgan stuartmorgan deleted the tool-update-pub-credential-location branch May 11, 2023 10:11
stuartmorgan added a commit to stuartmorgan/packages that referenced this pull request May 11, 2023
@stuartmorgan
[ci] Pin the Flutter version for release
b4258d5 
Pins to a specific version of Flutter, rather than using a branch, to
avoid issue like flutter#3962 being
surprise out-of-band failures.
@stuartmorgan stuartmorgan mentioned this pull request May 11, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request May 11, 2023
@stuartmorgan
[ci] Pin the Flutter version for release (#3965)
5a2337f 
Pins to a specific version of Flutter, rather than using a branch, to avoid issue like #3962 being surprise out-of-band failures.

This does not change current behavior, as `stable` currently points to the same commit as `3.10.0`.
@reidbaker reidbaker mentioned this pull request May 12, 2023
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5b7d732 [tool] Use new pub cache location for publish (flutter/packag…
e3a1ec2 
…es#3962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5b7d732 [tool] Use new pub cache location for publish (flutter/packag…
5455406 
…es#3962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5b7d732 [tool] Use new pub cache location for publish (flutter/packag…
699e4f1 
…es#3962)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (#126865)
96580f5 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (flutter#126865)
e39437c 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan @nploi
[tool] Use new pub cache location for publish (flutter#3962)
8e0e6f4 
As of Dart 3.0 (Flutter 3.10), the location that the tool was using for
the pub cache wasn't being read, breaking autopublish in CI. This
updates to the new location, and adds tests for it.

Should fix the fact that the `release` step hangs on every package
change now.
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan @nploi
[ci] Pin the Flutter version for release (flutter#3965)
d68beeb 
Pins to a specific version of Flutter, rather than using a branch, to avoid issue like flutter#3962 being surprise out-of-band failures.

This does not change current behavior, as `stable` currently points to the same commit as `3.10.0`.
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@ditman ditman Awaiting requested review from ditman

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan @tarrinneal