[camerax] Small fixes to starting/stopping video capture #6068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
changed the title
11 tasks
gmackall
approved these changes
Feb 8, 2024
Ah Reid recommended this for another PR but that's the only time I've done it. I have no prob just writing the fixes out, though, so I can do that :) |
|
@gmackall I assumed that unbinding |
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 9, 2024
flutter/packages@29d8cc0...11152d2 2024-02-09 [email protected] [webview_flutter] Add interface for showing javascript dialog message (flutter/packages#4704) 2024-02-09 [email protected] [pigeon] Implement Screaming Snake Case Conversion for Kotlin Enum Cases (flutter/packages#5918) 2024-02-09 [email protected] [camerax] Small fixes to starting/stopping video capture (flutter/packages#6068) 2024-02-08 [email protected] Roll Flutter from 8431cae to eb5d0a4 (33 revisions) (flutter/packages#6079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
…eOffset` (#6059) This PR implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` and makes some small fixes here and there, each of which I have left a comment about for context. Part of flutter/flutter#120468 & flutter/flutter#120467. ~NOTE: Should land after #6068 done :)
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Fixes small issues I noticed in starting/stopping video capture while working on flutter#6059, notably: - Change all remaining `unawaited` calls to `await` to avoid any racy behavior. - Update `camera` info after `VideoCapture` use case is bound to the lifecycle of the plugin's `ProcessCameraProvider` to make sure it is up to date. - ~Unbind `VideoCapture` use case when video recording stops since it was suggested to lazily load it for performance reasons (open to pushback on this).~ this would require potentially more changes than I originally thought - Make tests checking that async methods throw exceptions actually wait for those exceptions as this may cause flaky test behavior. Fixes flutter/flutter#132499 as this PR removes any remaining `unawaited` calls.
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…eOffset` (flutter#6059) This PR implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` and makes some small fixes here and there, each of which I have left a comment about for context. Part of flutter/flutter#120468 & flutter/flutter#120467. ~NOTE: Should land after flutter#6068 done :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes small issues I noticed in starting/stopping video capture while working on #6059, notably:
unawaitedcalls toawaitto avoid any racy behavior.camerainfo afterVideoCaptureuse case is bound to the lifecycle of the plugin'sProcessCameraProviderto make sure it is up to date.Unbindthis would require potentially more changes than I originally thoughtVideoCaptureuse case when video recording stops since it was suggested to lazily load it for performance reasons (open to pushback on this).Fixes flutter/flutter#132499 as this PR removes any remaining
unawaitedcalls.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).