-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[local_auth] Switch iOS endorsement to local_auth_darwin
#6107
[local_auth] Switch iOS endorsement to local_auth_darwin
#6107
Conversation
local_auth_darwin
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I was hoping to have macOS support land in |
* Updates support matrix in README to indicate that iOS 11 is no longer supported. | ||
* Clients on versions of Flutter that still support iOS 11 can continue to use this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because it no longer makes sense; with 3.16.6 as the minimum, nobody supporting iOS 11 can use this version of local_auth
anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
auto label is removed for flutter/packages/6107, due to - The status or check suite Linux_android android_platform_tests_api_33_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/packages/6107, due to - The status or check suite Linux_android android_platform_tests_api_33_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/packages/6107, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@48048f6...078c2a3 2024-02-22 [email protected] Manual roll Flutter from 5129806 to efee280 (47 revisions) (flutter/packages#6180) 2024-02-22 [email protected] Manual roll Flutter (stable) from bae5e49 to abb292a (1 revision) (flutter/packages#6179) 2024-02-21 [email protected] [in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165) 2024-02-21 [email protected] [camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each (flutter/packages#6109) 2024-02-21 [email protected] [camerax] Implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` (flutter/packages#6059) 2024-02-21 [email protected] [various] Commit Windows build migrations (flutter/packages#6175) 2024-02-21 [email protected] [flutter_markdown] Support wasm (flutter/packages#6168) 2024-02-21 [email protected] [ci] Run Windows Arm64 build tests post-submit (flutter/packages#6166) 2024-02-21 [email protected] [url_launcher] Remove `renderView` usage (flutter/packages#6137) 2024-02-21 [email protected] [camera_android_camerax] Fix typo in readme (flutter/packages#6143) 2024-02-21 [email protected] [local_auth] Switch iOS endorsement to `local_auth_darwin` (flutter/packages#6107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updates to use
local_auth_darwin
instead of the discontinuedlocal_auth_ios
.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).