[google_sign_in] Clean up pre-Pigeon code #6141
Conversation
Internal native helper code was still using `id` arguments, doing type checking, and handling `NSNull`, none of which is relevant now that the calling code has been converted to Pigeon and is already strongly typed as `NSString`.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
|
I just happened to see this and it made me sad, so I thought I'd clean it up :) |
packages/google_sign_in/google_sign_in_ios/darwin/Classes/FLTGoogleSignInPlugin.m
Outdated
Show resolved
Hide resolved
| - (GIDConfiguration *)configurationWithClientIdentifier:(NSString *)runtimeClientIdentifier | ||
| serverClientIdentifier:(NSString *)runtimeServerClientIdentifier | ||
| hostedDomain:(id)hostedDomain { | ||
| NSString *clientID = runtimeClientIdentifier ?: self.googleServiceProperties[kClientIdKey]; |
There was a problem hiding this comment.
Don't you need to check if self.googleServiceProperties is null before getting a key from it? Wouldn't it error/crash if it's null?
There was a problem hiding this comment.
Nope! foo[bar] is just a shorthand for [foo objectForKeyedSubscript:bar], so standard messaging rules (a message to nil returns zero'd memory, nil in this case) apply.
There was a problem hiding this comment.
(Notice that the previous serverClientID code was actually already relying on that, so this code wasn't even consistent about the overkill 🙂)
packages/google_sign_in/google_sign_in_ios/darwin/Classes/FLTGoogleSignInPlugin.m
Show resolved
Hide resolved
stuartmorgan
added
the
autosubmit
flutter/packages@ef349be...c56c12d 2024-02-16 [email protected] [tool] Add support for using a Kotlin test runner file (flutter/packages#6131) 2024-02-16 [email protected] [in_app_purchase] fix skerror nullability (flutter/packages#6139) 2024-02-15 [email protected] Explicitly pass the web renderer into the tests. (flutter/packages#6140) 2024-02-15 [email protected] [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141) 2024-02-15 [email protected] [local_auth] Add compatibility with latest `intl` (flutter/packages#6138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Internal native helper code was still using `id` arguments, doing type checking, and handling `NSNull`, none of which is relevant now that the calling code has been converted to Pigeon and is already strongly typed as `NSString`.
Internal native helper code was still using
idarguments, doing type checking, and handlingNSNull, none of which is relevant now that the calling code has been converted to Pigeon and is already strongly typed asNSString.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).