[two_dimensional_scrollables] Fix layout offset of merged pinned cells #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
the
p: two_dimensional_scrollables
|
Just when I thought #5917 had all the tests! 🤣 |
goderbauer
approved these changes
Feb 22, 2024
packages/two_dimensional_scrollables/test/table_view/table_test.dart
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 23, 2024
flutter/packages@078c2a3...7df2085 2024-02-22 [email protected] [web] Removes a few deprecated API usages. (flutter/packages#6177) 2024-02-22 [email protected] [two_dimensional_scrollables] Fix layout offset of merged pinned cells (flutter/packages#6178) 2024-02-22 [email protected] Roll Flutter from efee280 to 41581c9 (1 revision) (flutter/packages#6181) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
flutter#6178) Fixes flutter/flutter#143526 This fixes the layout offset computation when there are merged cells within pinned rows and/or columns in TableView.
11 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
flutter#6178) Fixes flutter/flutter#143526 This fixes the layout offset computation when there are merged cells within pinned rows and/or columns in TableView.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#143526
This fixes the layout offset computation when there are merged cells within pinned rows and/or columns in TableView.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.