[flutter_adaptive_scaffold] : 🐛 #141938 - Drawer stays open even on destination tap. #6289
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gspencergoog
added
the
autosubmit
|
auto label is removed for flutter/packages/6289, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
Looks like you'll need to update the CHANGELOG: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752843542649031841/+/u/Run_package_tests/CHANGELOG_and_version_validation/stdout |
|
@gspencergoog Can I update NEXT with 0.1.8+1? Will that work? |
|
|
||
| ## 0.1.8+1 |
There was a problem hiding this comment.
I'd just eliminate these lines and put all the changes into 0.1.9, since 0.1.8+1 will not be published.
There was a problem hiding this comment.
Removed 0.1.8+1 and merged those change sets into 0.1.9
gspencergoog
added
the
autosubmit
…en on destination tap. (flutter/packages#6289)
flutter/packages@23e56af...b7fbe68 2024-03-21 [email protected] [adaptive_scaffold] : � #141938 - Drawer stays open even on destination tap. (flutter/packages#6289) 2024-03-20 [email protected] [camera_android] Update README to encourage users to use CameraX implementation (flutter/packages#6353) 2024-03-20 [email protected] Roll Flutter from d31a85b to b96c13d (19 revisions) (flutter/packages#6359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
aliasgar4558
changed the title
…on tap. (flutter#6289) (#141938) *Changes included in PR are listed as follows* - As per material guidelines, Drawer shall be dismissed when user taps any destination/item. If drawer is open, and user taps on any item, before calling onDestinationSelected() - we are now dismissing drawer. - CHANGELOG.md file updated. - Updated to v0.1.9. *Issue : flutter/flutter#141938
(#141938)
Changes included in PR are listed as follows
Issue : flutter/flutter#141938
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.